Since we frequently need a new test module for some test, our tests/ directory is more and more flooded by them. However, I now see that Core actually in most cases puts them inside a nested tests/modules/ folder, which seems a lot more ordered to me.
While this has the potential to make some re-rolls necessary, I’d still say we should make this move, too.

CommentFileSizeAuthor
#6 2022-03-04_13-52.png20.07 KBmarciaibanez
#4 3262771-4--move_test_modules_to_subfolder.patch43.82 KBdrunken monkey
#4 3262771-4--move_test_modules_to_subfolder--interdiff.txt1.61 KBdrunken monkey
#2 3262771-2--move_test_modules_to_subfolder.patch42.22 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3262771-2--move_test_modules_to_subfolder.patch42.22 KB

This would implement the move. (I chose not to do the same for the Database Search module, as there is only a single test module in there. If we ever add a second one, we can just create the modules/ folder then.)

Status: Needs review » Needs work

The last submitted patch, 2: 3262771-2--move_test_modules_to_subfolder.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 3262771-4--move_test_modules_to_subfolder--interdiff.txt1.61 KB
new 3262771-4--move_test_modules_to_subfolder.patch43.82 KB
marciaibanez’s picture

marciaibanez
she/her
Primary language Portuguese, Brazil
Location São Paulo
commented
Assigned: Unassigned » marciaibanez

I'll review this.

marciaibanez’s picture

marciaibanez
she/her
Primary language Portuguese, Brazil
Location São Paulo
commented
Assigned: marciaibanez » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2022-03-04_13-52.png20.07 KB

I tested the patch and everything seems to be working perfectly :)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Great to hear, thanks a lot for reviewing!
Committed.

  • drunken monkey committed db20833 on 8.x-1.x 
    Issue #3262771 by drunken monkey, marciaibanez: Moved test modules to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.