The settings form can't be submitted if "Enable "Thank you" banner" is not checked.

Chrome shows "An invalid form control with name='popup_agreed[value]' is not focusable" error in the browser console.
The "required" attribute of popup_agreed[value] textarea is not cleared when "Enable "Thank you" banner" is unchecked.

The same issues:
#2977230: Can't submit eu cookie compliance settings form
#2964785: I can't submit eu cookie compliance settings form

Issue fork eu_cookie_compliance-3262506

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

maximpodorov created an issue. See original summary.

svenryen’s picture

svenryen commented

Hi @maximpodorov!

Thank you for the report.

Can you please try to fill in a value in the fields "More info button label"and "Hide button label" and try again?

maximpodorov’s picture

maximpodorov commented

The form is not submitted until "Thank you" banner message field is set, but not every time. I must reload the page several times to make the form be submittable. A race of several Drupal behaviors?

svenryen’s picture

svenryen commented

We don't have multiple Drupal behaviors, unless there's another module interfering, which I doubt.

The fields below "Enable Thank you banner" currently require a value present even if the option is disabled. You can enter any value, it doesn't really matter what the values are when the feature is disabled.

manuga’s picture

manuga commented

I have the same problem in a multisite Drupal 7.
When the name of my subdomain is diferent of the name of the site in Drupal, so i have a sites/sites.php indicating de change..
$sites['SUBDOMAIN'] = 'FOLDER IN DRUPAL';

What it works for me, is to go to "Thank you banner message" field and change ckeditor format to plain text. Then I can save the form correctly..

svenryen opened merge request !62

svenryen’s picture

svenryen commented
Status: Active » Needs review

@manuga and @maximpodorov , can you try this patch and see if it resolves your issue?

You may need to rebuild cache in order to see the javascript changes introduced.

The module now properly sets the fields in question as not required so it should be possible to submit the config when there's no value for the Thank you banner and the option to show it has been disabled.

https://git.drupalcode.org/project/eu-cookie-compliance/-/merge_requests...

manuga’s picture

manuga commented

I can't try it, I don't have that site anymore.. sorry.

  • svenryen committed 6740c4d on 8.x-1.x 
    Issue #3262506 by svenryen, maximpodorov, manuga: Can't submit eu cookie...
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.