The tables on bibcite/reference/* pages have their header cells in 'td' elements instead of 'th'. This creates an accessibility problem. These should be <th scope="row">.

Issue fork bibcite-3262280

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !6

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
Issue tags: +Accessibility
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This should have a test. The best way to do this would be to commit #3262277: References table has no header for bibcite_links and then I will adjust the tests added in that issue.

aardwolf’s picture

aardwolf commented
Status: Needs review » Needs work

Hi @Liam Morland
Tested patch on branch 3.0.x with #3262277: References table has no header for bibcite_links.
Got an error.

Drupal\Tests\bibcite_entity\Functional\BibciteEntityTest::testReferenceTable
Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//div[contains(@class, "bibcite-reference-table")]//tr[td[text() = "Download citation"]][td//a[text() = "Google Scholar"]]" not found

.
We plan to fix it later.
You can update your MR if you know the way how it should be fixed.
Thank you.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Probably just replacing td with th in the test. I don't really have time to investigate; I work for a new employer now and we are not using bibcite.

aardwolf’s picture

aardwolf commented
Version: 2.0.x-dev » 3.0.x-dev

  • hxdef committed 37127c0d on 3.0.x authored by Liam Morland 
    Issue #3262280: Headers in references tables do not use 'th' elements
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

It should probably only be the title row that becomes th.

AardWolf credited hxdef.

aardwolf’s picture

aardwolf commented
Status: Needs work » Fixed
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Fixed » Needs work

The change as it was committed makes all the table cells th. It should be the first column that is th and the second still a td. This is what I did in my merge request.

  • hxdef committed 18b57951 on 3.0.x 
    Issue #3262280: Headers in references tables do not use 'th' elements
aardwolf’s picture

aardwolf commented
Status: Needs work » Fixed

Liam Morland closed merge request !6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.