Closed (fixed)
Project:
Address Map (& Directions) Link
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Feb 2022 at 22:48 UTC
Updated:
30 May 2022 at 17:09 UTC
Jump to comment: Most recent
Comments
Comment #2
chrissnyderI think this is related to an issue in Drupal core #3015152: Support third-party settings for components within a section. Once that is resolved, this may work with layout builder.
Comment #3
chrissnyderComment #4
cwyattjibc commentedIs this bug the cause of the formatting change I've witnessed on my site? Address no longer has spaces "New WestminsterBCV3K 5T5
Canada". Specifically this span class
<span class="administrative-area">BC</span>. Drupal 9.3.9Comment #5
anybodyI can sadly confirm this issue. :( Added this one as child issue of #3015152: Support third-party settings for components within a section. This is annoying, I was so happy to find this helpful module. Not sure when this will be fixed in core, should we implement a workaround?
I also tried with the latest patch from the core issue, but it doesn't work.
$field_display variable in address_map_link_preprocess_field looks like this:
I'm not sure yet if the core patch isn't perfect yet or if there's a mistake in the implementation of this module.
Comment #7
anybodyJust compared this to https://www.drupal.org/project/fences/ which works in layout builder and added the differences and missing schema to the MR. Still WIP.
@ChrisSnyder side-topic: Perhaps enable automated testing for issues?
Comment #8
anybodyYay! It works, and I guess it might also work without the core patch. Please try with and without layout builder using the patch from MR1:
https://git.drupalcode.org/project/address_map_link/-/merge_requests/1.diff
And please check, if the core patch is required. I think it's not.
Comment #9
anybodyComment #10
anybodyComment #11
chrissnyderAutomated testing has been updated for issues/commits (was configured for an old/unsupported version of PHP).
@Anybody, does it work without patching core?
Comment #12
anybody@ChrisSnyder, we'll have to try it. I can't say as the core patch contained a DB update and I didn't roll that back...
Comment #13
anybody@ChrisSnyder it works and fixes an implementation issue. Could you perhaps review and commit this? If you can't use Layout Builder, please at least check the functionality still works correctly without layout builder :)
Comment #14
chrissnyderThanks for your work on this. I tested it with both layout builder and when layout builder was not installed.
Comment #16
anybodyCoooooool, thanks!!! :)