Problem/Motivation

Running system_post_update_entity_revision_metadata_bc_cleanup() after updating from 8.9.20 to 9.3.3 results in the following error:

> [notice] Update started: system_post_update_entity_revision_metadata_bc_cleanup
> [error] Drupal\feeds\FeedStorage does not implement Drupal\Core\Entity\ContentEntityStorageInterface
> [error] Update failed: system_post_update_entity_revision_metadata_bc_cleanup

Proposed resolution

Fix the bug.

Remaining tasks

Fix the bug.

User interface changes

n/a

API changes

TBD

Data model changes

TBD

Issue fork feeds-3261958

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Feeds was uninstalled but the key_values still remained.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3261968: Delete key_value values in hook_uninstall()

Given the module was uninstalled it means that the module didn't clean up after itself properly, so #3261968: Delete key_value values in hook_uninstall() should help.

MegaChriz made their first commit to this issue’s fork.

MegaChriz opened merge request !50

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review

I've made FeedStorageInterface extending ContentEntityStorageInterface, let's see if tests still pass.

  • MegaChriz committed 4bda84b on 8.x-3.x 
    Issue #3261958 by MegaChriz: Drupal\feeds\FeedStorage does not implement...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Merged.

megachriz’s picture

megachriz
Primary language Dutch
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.