[D9] Cookie Block

Thank you for applying!

The 8.x-1.0 branch has a wrong name; it needs to be removed. The other branch names are correct.

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear

    if (!empty($this->configuration['negate'])) {
      return t('The cookie @cookie_id is not @cookie_value.', [
        '@cookie_id' => $this->configuration['cookie_id'],
        '@cookie_value' => $this->configuration['cookie_value'],
      ]);
    }
    return t('The cookie @cookie_id is @cookie_value.', [
      '@cookie_id' => $this->configuration['cookie_id'],
      '@cookie_value' => $this->configuration['cookie_value'],
    ]);

t() should not be used in a class that uses DI. In that case, the class should also use the StringTranslationTrait trait.

    $cookies = \Drupal::request()->cookies;

\Drupal should not be used from a class that uses DI.

Ran a quick scan. See results below:

FILE: /cookie_block/src/Plugin/Condition/CookieCondition.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  88 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 103 | WARNING | Unused variable $default_value.
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /cookie_block/src/Plugin/Condition/CookieCondition.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 33 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------

Thank you for your contribution! I am going to update the project.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.