Closed (duplicate)
Project:
Mailer Plus (DSM+)
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Feb 2022 at 08:58 UTC
Updated:
5 Feb 2022 at 09:15 UTC
Jump to comment: Most recent
Comments
Comment #2
drcolossos commentedSince I already needed attaching files from a path, I simply uncommented the attach() function from the BaseEmailInterface and implemented it via BaseEmailTrait by directing the attach() call to $this->inner->attach(). Works without a probem (ignoring the permissions stuff etc since it is not needed)
Comment #3
adamps commentedThanks, good to have an issue for this. There is a patch equal to #2 on #3261807: [META] Attachments support. However it cannot be committed until the security is done, and that's quite hard. I would also like to test out some different use cases (see "features and status" linked from the IS for some ideas) to confirm the interface is right before commit. In fact I would even say we should have tests for these different use cases - which means we would need to create the testing framework first.
In my mind this is not the top priority for me to spend time on as it seems quite specialised/complex and many of the basics are also still not present. Anyone who is keen to use it earlier can apply the linked patch.
Comment #4
seanbLet's close this as a duplicate since the other issue has a patch. We'll focus our efforts there.