Problem/Motivation

.engine files are not scanned as part of the PHPCS scan. Lets do that. They are PHP.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3261574-8.patch4.03 KBkunalgautam
#7 3261574-7.patch4.06 KBkunalgautam
#6 interdiff_2-6.txt3.42 KBkunalgautam
#6 3261574-6.patch3.9 KBkunalgautam
#5 3261574-nr-bot.txt143 bytesneeds-review-queue-bot
#2 3261574-2.patch3.88 KBalexpott

Issue fork drupal-3261574

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3261574-2.patch3.88 KB

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3261574-nr-bot.txt143 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

kunalgautam’s picture

kunalgautam commented
StatusFileSize
new 3261574-6.patch3.9 KB
new interdiff_2-6.txt3.42 KB

Patch for Drupal version 10.1.x

kunalgautam’s picture

kunalgautam commented
StatusFileSize
new 3261574-7.patch4.06 KB

PHPCS fixes

kunalgautam’s picture

kunalgautam commented
StatusFileSize
new 3261574-8.patch4.03 KB
kunalgautam’s picture

kunalgautam commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Think there are a number of files that are outside the scope of the issue.

quietone’s picture

quietone commented
Issue tags: +Coding standards

quietone opened merge request !3942

quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Changes in the MR 3942 look good.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 0a6ff2635d to 11.x (10.2.x). Thanks!

  • longwave committed 0a6ff263 on 11.x 
    Issue #3261574 by quietone, kkalashnikov, alexpott, smustgrave: Add ....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.