Problem/Motivation

There's functions deprecated for removal in core 10

Proposed resolution

remove the usage, make sure no mentions left

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

Comments

andypost created an issue. See original summary.

andypost’s picture

Status: Active » Needs review
StatusFileSize
new14.44 KB
andypost’s picture

StatusFileSize
new458 bytes
new14.67 KB

fix CS

andypost’s picture

longwave’s picture

Status: Needs review » Needs work

Two more:

core/modules/taxonomy/src/Controller/TaxonomyController.php
38:   * @deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. There is no
44:    @trigger_error(__METHOD__ . ' is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. There is no replacement; route title callbacks are internal. See https://www.drupal.org/project/drupal/issues/3037157.', E_USER_DEPRECATED);

core/modules/taxonomy/src/Plugin/views/argument_validator/Term.php
12: * @deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use
23:    @trigger_error('The ' . __NAMESPACE__ . '\Term is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal\views\Plugin\views\argument_validator\Entity instead. See https://www.drupal.org/node/3221870', E_USER_DEPRECATED);

Also term_access query tag was never fully deprecated, this needs its own issue(s):

      // TODO:
      // - Extract this mechanism into a hook as part of a public (non-security)
      //   issue.
      // - Emit E_USER_DEPRECATED if term_access is used.
      //   https://www.drupal.org/node/2575081
      $term_access_tags = ['term_access' => 1, 'taxonomy_term_access' => 1];
      if (array_intersect_key($this->alterTags, $term_access_tags)) {
        $this->alterTags += $term_access_tags;
      }
andypost’s picture

Status: Needs work » Needs review
Related issues: +#3039039: Deprecate some procedural functions in taxonomy.module, +#3037157: Vocabulary name not translated in page title of the taxonomy overview and reset forms, +#3221149: Remove dead code in Taxonomy's Views handlers
StatusFileSize
new2.75 KB
new17.42 KB
longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thank you @andypost, this looks ready now.

quietone’s picture

I agree I applied the patch and checked didn't find any occurrences of the removed functions.

longwave’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
andypost’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new829 bytes
new17.3 KB

re-rolled

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, back to RTBC assuming tests are green.

andypost’s picture

Title: Remove deprecated taxonomy.module functions » Remove deprecated taxonomy module functions

Thanks! fixing title

quietone’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies

andypost’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new755 bytes
new17.23 KB

re-rolled, that's last static deprecation from bootstrap))

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks again, back to RTBC again!

quietone’s picture

Status: Reviewed & tested by the community » Needs work

I found another one.

core/modules/taxonomy/src/Plugin/views/filter/TaxonomyIndexTid.php: @trigger_error('The current_user service must be passed to ' . __NAMESPACE__ . '\TaxonomyIndexTid::__construct(). It was added in drupal:8.9.0 and will be required before drupal:10.0.0.', E_USER_DEPRECATED);

andypost’s picture

Status: Needs work » Needs review
StatusFileSize
new1.39 KB
new18.62 KB

Thank you! fixed

daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed da3c102 on 10.0.x
    Issue #3261240 by andypost, longwave, quietone: Remove deprecated...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Great to see the entity-providing modules getting lighter.

Committed da3c102 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.