https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/themes/claro...
REMs are supported even in IE9. There is no need to define margins using pixels.

CommentFileSizeAuthor
#10 3261049-10.patch1.68 KBgauravvvv
#10 interdiff-3261049-5_10.txt858 bytesgauravvvv
#8 remove_duplicate_margin-3261049-8.patch1.65 KBechechulina
#5 3261049-5.patch868 byteselber

Comments

chi’s picture

chi commented

We might need to fix same bug in Seven as well.

chi’s picture

chi commented
Issue summary: View changes
chi’s picture

chi commented
Issue summary: View changes
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Active » Needs review
StatusFileSize
new 3261049-5.patch868 bytes
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
chi’s picture

chi commented
Status: Needs review » Needs work

The typography.css file needs to be compiled.
https://www.drupal.org/node/3084859

echechulina’s picture

echechulina commented
Status: Needs work » Needs review
StatusFileSize
new remove_duplicate_margin-3261049-8.patch1.65 KB

The duplicated margin properties were removed from typography css

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

#8 doesn't apply, it doesn't have the "core" directory as the first component of the file path.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new interdiff-3261049-5_10.txt858 bytes
new 3261049-10.patch1.68 KB

I have provided the compiled patch, Fixed the custom commands. Attached interdiff for same. Please review.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Should we configure stylelint to disallow this?

https://stylelint.io/user-guide/rules/list/declaration-block-no-duplicat...

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Bug Smash Initiative

@longwave Does the patch need updating?

Checked the patch in #10 and it applies cleanly for 9.3, 9.4, and 10.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

#12 can be moved to a followup, I tried it locally but there are a number of wider issues that need discussing.

Therefore to me #10 is RTBC.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Opened #3265606: Enable declaration-block-no-duplicate-properties in Stylelint for followup.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Remove duplicated margin properties form typography CSS » Remove duplicated margin properties from typography CSS

Fix title.

  • lauriii committed 3effb67 on 10.0.x 
    Issue #3261049 by Gauravmahlawat, elber, Elena Chechulina, longwave, Chi...

  • lauriii committed 1d09ab1 on 9.4.x 
    Issue #3261049 by Gauravmahlawat, elber, Elena Chechulina, longwave, Chi...

  • lauriii committed db4c9ef on 9.3.x 
    Issue #3261049 by Gauravmahlawat, elber, Elena Chechulina, longwave, Chi...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 3effb67 and pushed to 10.0.x. Also cherry picked to 9.4.x and 9.3.x since Claro is experimental. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.