Closed (fixed)
Project:
Views Bootstrap
Version:
5.5.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Jan 2022 at 12:51 UTC
Updated:
24 May 2024 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lamp5It is first schema for bootstrap grid, nice for first commit and continuing works.
Comment #4
shelaneComment #5
paweldxm commentedNew .patch include more missing values in schema.
Comment #6
splash112 commentedYes, please! But make some taxtfields "label" so they can be translated. Using the following now:
Comment #7
paweldxm commentedI added simple labels. Additionally, I added the missing schema for table.
Comment #8
anybodyI can confirm this issue. This can be simply reproduced by using config_inspector module:
Affected config example:
Comment #11
grevil commentedSome of these options are never actually used?
"ViewsBootstrapGrid" for example defines loads of options in "defineOptions" but, basically, all of them are not even in use...
Defining these to override core Grid options (like "col_class_default" or "col_class_custom") would make sense if we extend "Drupal\views\Plugin\views\style\Grid", but the "ViewsBootstrapGrid" class is extending "StylePluginBase" instead. So there seems to be no way, to actually change these options, since no UI is provided? Or am I missing something here?
Comment #12
grevil commentedAlright, that should be it. I adjusted the schema and a few default_values. If we want to be 100% clean, we need to provide update hooks for some views style plugins, to map their values to the new ones, in case they are using the default values. But the maintainers should decide here.
Comment #13
anybodyComment #14
grevil commentedComment #15
anybodyLGTM, but a maintainer or someone else should please take a final look & test and RTBC this.
Comment #17
shelane