Closed (fixed)
Project:
Project
Version:
5.x-1.x-dev
Component:
Usage statistics
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
25 Oct 2008 at 15:19 UTC
Updated:
8 Nov 2008 at 17:52 UTC
It'd be slightly nicer if we were using project uri links for the overview usage summary table, instead of project nid links.
See http://project.drupal.org/project/usage
| Comment | File | Size | Author |
|---|---|---|---|
| project_usage_overview_uri_links.patch | 1.51 KB | dww |
Comments
Comment #1
aclight commentedpatch looks good.
One concern about doing this. The pages this code is used on are currently cached for 1 day (but really could be cached for 1 week, since the statistics are only updated once per week). That means that if a project maintainer were to change the short_name (uri) of a project, then links from the usage statistics would return 404 errors for up to one day (or one week, if cache lifetime is increased in the future). This isn't that big of a deal, but I wonder if the benefit of having the uri in the URL outweighs the downside of the possibility that we'll be serving pages with bad links.
Comment #2
dwwWe could also clear this cache whenever a project's shortname changes. Changing the shortname is sort of a big deal already b/c of /project/[foo] linkrot, CVS directory renaming, etc. Perhaps we should make it harder to change a shortname in the first place. ;)
Comment #3
aclight commentedYeah, that's true. I'd be in favor of restricting who can change the short name of projects.
Comment #4
sunLooks good, and much better than mine ;)
Also, +1 for caching this data for a week. I really wonder how often projects are renamed? Given the other mentioned implications, I'd say: who cares if that link does not work for 7 days at max?
Comment #5
webchickI'd say it's not a huge deal if the links are dead for 7- days. Discourages people from changing their shortnames, which breaks other links as well.
This change sounds great! :)
Comment #6
dwwCommitted to HEAD and DRUPAL-5, deployed on d.o, cache cleared.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.