Problem/Motivation

In Drupal 9, attempting to save the settings form located at /admin/commerce/pos/settings results in a fatal error:
Error: Call to undefined function Drupal\commerce_pos\Form\file_prepare_directory() in Drupal\commerce_pos\Form\CommercePOSSettingsForm->submitForm()

Steps to reproduce

  1. Install Commerce POS in Drupal 9
  2. Navigate to POS settings page at /admin/commerce/pos/settings
  3. Make a change and attempt to save the page

You should see a fatal error.

Proposed resolution

As per https://www.palantir.net/rector/updating-deprecated-filepreparedirectory..., references to the deprecated file_prepare_directory() function should be replaced with \Drupal::service('file_system')->prepareDirectory($directory, $options);.

Remaining tasks

Test patch (coming in next comment)

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 commerce_pos-replace_deprecated_function_call-3260249-2.patch652 bytesamklose

Comments

amklose created an issue. See original summary.

amklose’s picture

amklose
he/him
Primary language English
Location Wisconsin
commented
StatusFileSize
new commerce_pos-replace_deprecated_function_call-3260249-2.patch652 bytes

Here's a patch that replaces the deprecated call in CommercePOSSettingsForm.php

amklose’s picture

amklose
he/him
Primary language English
Location Wisconsin
commented
Status: Active » Needs review

Changing status.

ppblaauw’s picture

ppblaauw commented

The patch works for me

luksak’s picture

luksak
he/him
commented
Status: Needs review » Reviewed & tested by the community

Works for me. Thank you!

_gramur’s picture

_gramur commented

This works for me as well.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

  • alexpott committed 379a277f on 8.x-2.x authored by amklose 
    Issue #3260249 by amklose: Call to deprecated function...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.