Problem/Motivation

The sub-module "Sendgrid Integration Reports" is not working with the API key implementation.

Steps to reproduce

1. Install the following modules: sendgrid_integration, sendgrid_integration_reports, key
2. Create API key and assign the key in Sendgrid settings page.
3. Now visit the report page "admin/reports/sendgrid". You will see no data available.

Proposed resolution

Create a patch to fix the bug.

CommentFileSizeAuthor
#5 3259693-5.patch1.2 KBidebr
#3 sendgrid_integration-325963-21012022-2.patch805 bytesfinaukaufusi
#2 sendgrid_intergration-325963-21012022-1.patch805 bytesfinaukaufusi

Comments

finaukaufusi created an issue. See original summary.

finaukaufusi’s picture

finaukaufusi
Primary language English
Location Sydney
commented
StatusFileSize
new sendgrid_intergration-325963-21012022-1.patch805 bytes

Here's a patch to fix the api key.

finaukaufusi’s picture

finaukaufusi
Primary language English
Location Sydney
commented
StatusFileSize
new sendgrid_integration-325963-21012022-2.patch805 bytes

Upload the correct patch file.

perignon’s picture

perignon commented
Status: Active » Needs work

I believe this has already been addressed. Switch to the 2.x dev to get the latest updates.

Also for most all modules you will find maintainers will want patches only against the latest dev, no one really patches old versions of modules.

idebr’s picture

idebr commented
Version: 8.x-1.7 » 8.x-2.x-dev
Assigned: finaukaufusi » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -status report
StatusFileSize
new 3259693-5.patch1.2 KB

This is still an issue on the 8.x-2.x branch.

Attached patch syncs the implementation of settings the API key between \Drupal\sendgrid_integration\Plugin\Mail\SendGridMail and \Drupal\sendgrid_integration_reports\Api, so the sendgrid.settings.apikey is interpreted as an API key even with the Key module installed.

anneke_vde’s picture

anneke_vde commented
Status: Needs review » Reviewed & tested by the community

I tested patch #5, when applied I see data at "admin/reports/sendgrid".

perignon’s picture

perignon commented
Status: Reviewed & tested by the community » Needs review

I would re-test with the latest dev code. This patch is out of date. Also just before this patch is this code which does the same thing:

if ($this->moduleHandler->moduleExists('key')) {
      $key = \Drupal::service('key.repository')->getKey($key_secret);
      if ($key && $key->getKeyValue()) {
        $this->apiKey = $key->getKeyValue();
      }
    }
    else {
      $this->apiKey = $key_secret;
    }
perignon’s picture

perignon commented
Status: Needs review » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.