Issue fork feeds-3259633

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dspachos created an issue. See original summary.

dspachos opened merge request !44

dspachos closed merge request !44

dspachos opened merge request !45

MegaChriz made their first commit to this issue’s fork.

  • MegaChriz committed da27e8a on 8.x-3.x authored by dspachos 
    Issue #3259633 by MegaChriz, dspachos: Added dependency injection for...
megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes
Status: Active » Fixed

Thanks, I tested manually if Drush commands still worked and they did.

I did correct:

  • Code comment in constructor (was saying it was created an other type of object).
  • Documented parameter $entity_type_manager in docblock of __construct().
  • Put namespace uses in alphabetical order.
megachriz’s picture

megachriz
Primary language Dutch
commented

Merging was a bit more challenging I guess because the branch from the forked repo had the same name.

dspachos’s picture

dspachos commented

@MegaChriz thanks for the corrections! As always, an extra pair of eyes is always better

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.