Problem/Motivation

  • Add a detailed view to SPA (K8s Daemonsets)

Issue fork cloud_dashboard-3259476

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !48

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas Patch for DaemonSet detailed view

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a detailed view to SPA (K8s Daemonset) » Add a detailed view to SPA (K8s DaemonSets)

@baldwinlouie

Thank you for adding the detailed view.

@ryo-yamashita

What do you think?

Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented

@yas

I have built the code and verified that it works. It looks fine to me. Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Thank you for your review.

@baldwinlouie

Could you please rebase the patch? Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, I've rebased the patch

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. I'll merge the patch to 4.x and close this issue as Fixed.

Also, Please push the patch into 3258116-release-4.0.0-prepare of #3258116: Release 4.0.0 Assigned to: yas. Thanks!

  • yas committed 0d2f4b5 on 4.x authored by baldwinlouie 
    Issue #3259476 by baldwinlouie, yas, Ryo Yamashita: Add a detailed view...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.