Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

Status: Needs work » Closed (duplicate)

I don't really understand the motivation for this patch.

Comment Notify was upgraded to 6.x in #203223: upgrade comment notify for 6.x and is available for download at http://drupal.org/node/320097

Also, this patch seems to have a lot of functional changes in it which generally should be left for separate issues instead of lumped together with the upgrade.

tobiasb’s picture

Title: Patch 5.x->6.x » 6.x-1.x-dev is broken, no Preview-button...
Status: Closed (duplicate) » Needs review

Ok, you are right. I'm sorry, but current 6.x... Version is broken and I just wanted to help. if is possible try the patch

greggles’s picture

Title: 6.x-1.x-dev is broken, no Preview-button... » Preview button lost in 6.x port
Status: Needs review » Needs work

Is the patch against the 6.x-1.x-dev version?

Frankly, I never liked that feature and feel it should be removed. Can you separate the patch into discrete units of fixes?

tobiasb’s picture

The first part

greggles’s picture

Title: Preview button lost in 6.x port » RFC - Provide a Preview button for 6.x?

Also, I think we should change this issue to a discussion of whether or not this is a valuable feature. There are 800+ people using the 6.x version and so far you are the first to notice this which makes me think we might want to drop support for it.

tobiasb’s picture

i use also only d6. i didn't need the feature, too. please, kick it.

greggles’s picture

greggles’s picture

Status: Needs work » Needs review

Forgot to change the status.

I'll leave this around for a few days to see if anyone else has feedback.

greggles’s picture

Assigned: Unassigned » greggles
Status: Needs review » Fixed

Applied to the 6.x-1.x branch.

This probably should not be backported.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.