Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2022 at 19:20 UTC
Updated:
10 May 2022 at 16:19 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #2
heddnComment #3
svenryen commentedThanks @heddn!
Comment #5
svenryen commentedComment #7
svenryen commentedI'm reverting and reopening this issue, since we can't remove that function from 8.x (I see now your patch was meant against 2.x and not 8.x-1.x. We'll have to see whether we can get 2.x out the door in time for the Drupal 10 beta or if we need to shift the current 2.x to 3.x and release a 2.x that's the same as 8.x-1.x but for 9.x/10.x only.
Most likely we can still use the same patch, and commit it to the proper branch when that time comes.
Comment #8
agoradesign commentedsee my comment in #3276060-6: ServiceNotFoundException: non-existent service "file_url_generator (8.x-1.x-dev is NOT Drupal 8 compatible!)
Comment #9
svenryen commented@agoradesign, I hear you, but I disagree. Experience with maintaining the module has told me that there are a lot of users on old drupal setups, and they deserve to get bug and security updates too.
Comment #10
svenryen commentedI have found a way to get the best of both worlds :)
Wrapping the old code in
if (\Drupal::VERSION < 9.3) {lets us safely add the new code from @heddn.In fact, according to https://www.drupal.org/node/2940031, it's possible to write just ->generateString(...).
Committing this to -dev.