Problem/Motivation

watchdog_exception('system', $e, 'An error occurred while notifying the creation of the @name field storage definition: "!message" in %function (line %line of %file).', ['@name' => $storage_definition->getName()]);

should be (!message) => (@message)

watchdog_exception('system', $e, 'An error occurred while notifying the creation of the @name field storage definition: "@message" in %function (line %line of %file).', ['@name' => $storage_definition->getName()]);

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3258969.patch1.08 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

Status: Active » Needs review
Issue tags: +Quick fix
StatusFileSize
new1.08 KB
tmaiochi’s picture

Assigned: Unassigned » tmaiochi

I'll do this review.

tmaiochi’s picture

Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
(5) Tested again with patch, issue resolved.
The patch works fine!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Testing this exception would be quite hard and probably not worth the effort of just fixing this.

Committed and pushed 421f02acd24 to 10.0.x and 438aab92387 to 9.4.x and 8b6b947bbd5 to 9.3.x. Thanks!

  • alexpott committed 421f02a on 10.0.x
    Issue #3258969 by heddn: Wrong argument for @message in ModuleInstaller...

  • alexpott committed 438aab9 on 9.4.x
    Issue #3258969 by heddn: Wrong argument for @message in ModuleInstaller...

  • alexpott committed 8b6b947 on 9.3.x
    Issue #3258969 by heddn: Wrong argument for @message in ModuleInstaller...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.