Closed (fixed)
Project:
Multiple Registration
Version:
3.0.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 Jan 2022 at 15:04 UTC
Updated:
1 Mar 2022 at 16:49 UTC
Jump to comment: Most recent
The module checks for hardcoded "/user" paths in lots of conditionals which means if the user route has been altered the module doesn't work as expected (for example, it checks whether it is on a '/user/register/{rid}' and '/user/{user}/edit' path to decide which form modes to check etc.).
Where the module checks for "user" paths, use route checks instead.
None.
Tweaks to conditionals in module functions.
None.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
littlepixiez commentedSorry about the terrible branch name... It's my first time using this new workflow on d.o!
I've done a commit changing the checks for the "/user" paths and used a route name check instead. It's all working as expected for me: the URLs are going to the correct rewritten registration paths and using the correct form display modes.
I guess my one question is whether this should remain hardcoded...
Which I think it probably can, as it's up to other modules to deal with the rewriting of this path, but I'm not sure.
PS. Thanks for the awesome module! I hope my use case can help others!
Comment #4
littlepixiez commentedComment #6
ysamoylenko commentedHello @littlepixiez,
Thank you for your contribution. Your changes make sense. They will be merged soon.
Comment #8
ysamoylenko commentedThe changes were merged.
Comment #9
ysamoylenko commentedThe changes were merged.