Image alt/title tag as photoswipe caption not working in entity reference fields

I have applied the patch and that fixes the referenced issue and now the formatter that i use in a display mode (/admin/structure/media/manage/image/display) works and the style is applied to the images i added inline using the ckeditor mediebutton with that display mode.
Thank you.

Thank you all! My fear is that committing this fix breaks something else in other cases... So we please need test coverage for the future. Hope you understand, we're jumping from one problem into the next as the module is very widely used in different scenarios.

This issue is blocked by missing test coverage for the photoswipe module.

Please first help to fix #2998694: Write tests for typical use-cases to reproduce this error, create a test and ensure the fix on this for all use-cases.
Hope you understand, we're jumping from one problem into the next as the module is very widely used in different scenarios.

See #2998694: Write tests for typical use-cases and help please. Until that, this issue is blocked.

Also see the comment from @Berdir in

https://www.drupal.org/project/photoswipe/issues/3132556#comment-14255411:

I also noticed the alt/title logic. That is clearly Drupal 7 code (those fields were/are defined by the file_entity module and the way the field value is accessed will not do anything in Drupal 8+, but I resisted the urge to clean that up.

Thank you very much, I just reviewed and tested this and committed to 3,x-dev. Please try 3.x-dev now :)

Thank you @balis_b, I'll have a look soon!

@dwisnousky what's that patch?

@balis_m: Thank you, looks good! I replaced the !empty check by ternary operator, see: https://stackoverflow.com/a/49464633/10031165

Could you please add tests for checking the alt and title tag as of #2998694: Write tests for typical use-cases? We have to stop introducing regressions to this module due to missing tests.

Still needs review, as I made changes, I can not review myself. Please also test manually.

Thank you @balis_m, let's get this committed to dev. :) Great work!