Problem/Motivation

VBO action on Group membership page throws error when you select any custom actions defined for Group membership view
error

Proposed resolution

Error was caused due to incorrect key being used to fetch Selected action label and as it was invalid key to fetch Label it was empty and hence calling `render` function on empty label caused above error.

CommentFileSizeAuthor
screenshot-pcpos11new.lndo_.site-2022.01.12-09_22_19.png496.5 KBhitesh-jain

Issue fork social-3258123

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hitesh-jain created an issue. See original summary.

hitesh-jain opened merge request !19

hitesh-jain’s picture

hitesh-jain commented
Status: Active » Needs review

tbsiqueira closed merge request !19

tbsiqueira’s picture

tbsiqueira
He/him
commented
Issue tags: +Open Social Batch 1
tbsiqueira’s picture

tbsiqueira
He/him
commented

Hi @Hitesh88, I added some comments to the PR: https://github.com/goalgorilla/open_social/pull/2696, I'm tagging it here for better communication.

tbsiqueira’s picture

tbsiqueira
He/him
commented
Status: Needs review » Needs work

  • tbsiqueira committed fed8af3 on 10.1.x 
    Issue #3258123 by hitesh-jain, tbsiqueira: VBO actions on Group...
tbsiqueira’s picture

tbsiqueira
He/him
commented

Commit HASH https://git.drupalcode.org/project/social/-/commit/fed8af3 has a wrong message, and is related to the back ported security release, please ignore this message.

hitesh-jain’s picture

hitesh-jain commented
Status: Needs work » Needs review

Hello @tbsiqueira I've updated this PR https://github.com/goalgorilla/open_social/pull/2696 with code suggestion as I don't have write access so left suggestions for you to check if you want I can create new PR with my fork with following changes. Let me know thanks

tbsiqueira’s picture

tbsiqueira
He/him
commented

Hi @hitesh-jain, thanks for the update. I added your suggestion, and changed a bit the logic ( inverted the if for the continue ).

Can you please test the change?

Kind regards :D

hitesh-jain’s picture

hitesh-jain commented
Status: Needs review » Reviewed & tested by the community

@tbsiqueira Looks good to me. thanks

  • Ressinel authored 51743e3 on 11.0.x 
    Merge pull request #2696 from goalgorilla/bugfix/3258123-vbo-actions-on-...

tbsiqueira credited Ressinel.

tbsiqueira’s picture

tbsiqueira
He/him
commented
Status: Reviewed & tested by the community » Fixed

  • Ressinel authored faac96e on 11.1.x 
    Merge pull request #2696 from goalgorilla/bugfix/3258123-vbo-actions-on-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.