Problem/Motivation

When something is reindexed using reindex page for dataset it should queue the item first? In \Drupal\data_pipelines\Form\DatasetBatchOperations it processes the items but doesn't queue those.

Steps to reproduce

Check the processing queue for a dataset.
Reindex the dataset by going to its reindex page.
Check the processing queue during reindexing request queue stays empty.

Proposed resolution

Queue the item for processing before index method is called in \Drupal\data_pipelines\Form\DatasetBatchOperations.

Remaining tasks

  • Review.
  • Commit.

User interface changes

Users can re-index the data from the reindex page now.

API changes

None

Data model changes

None.

CommentFileSizeAuthor
#5 3257923-5.patch5.21 KBjibran
#5 interdiff-73e13a.txt2.37 KBjibran
#4 3257923-4.patch3.57 KBjibran
#4 interdiff-e965de.txt1.5 KBjibran
#2 3257923-2.patch2.07 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 3257923-2.patch2.07 KB

Here we go.

Status: Needs review » Needs work

The last submitted patch, 2: 3257923-2.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-e965de.txt1.5 KB
new 3257923-4.patch3.57 KB

Fixed the test and added a new test for the new method.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-73e13a.txt2.37 KB
new 3257923-5.patch5.21 KB

\Drupal\data_pipelines\EntityHandlers\DatasetStorage::save also adds saved item to queue and then in \Drupal\data_pipelines\Form\DatasetForm::save we set the batch using \Drupal\data_pipelines\Form\DatasetBatchOperations::batchForDataset so here is the fix for that.

nterbogt’s picture

nterbogt commented
Status: Needs review » Reviewed & tested by the community

The changes appear to work for me.

  • acbramley committed eda4f05 on 1.x authored by jibran 
    Issue #3257923 by jibran: Queue the items before re-index
acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Fixed

I think I'd seen this before but just thought it was something else :D thanks guys

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.