Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Let's make this module Drupal 10 compatible!
This will primarily involve minor changes to deprecated code, and switching away from using "Classy" in the automated tests, since that has been removed in Drupal 10.
Issue fork layout_builder_restrictions-3257889
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
saphemmy commentedComment #3
saphemmy commentedI tried working on this but found this issue scope has been fixed in #3261244: Remove deprecated layout_builder module functions. Would someone be nice to review, validate and I also propose a closure to this issue
Comment #4
mark_fullmerThe issue referenced, #3261244: Remove deprecated layout_builder module functions is a Drupal core issue that actually removes the deprecated functions from the 10.x branch. This issue regards replacing deprecated functions in Layout Builder Restrictions with equivalents in Drupal 10.
I therefore don't believe this issue is resolved. Marking as "Active."
Comment #5
mark_fullmerComment #7
mark_fullmerComment #8
eiriksmI think we should remove support for versions less than 9.3.0 at the same time if we are doing this.
Which we can probably best do in a new branch?
Comment #9
mark_fullmerComment #10
eiriksmNice. Queued up a test of d10 that would be awesome if passed as well 🚀
Comment #11
mark_fullmerIt looks like the merge request as it is will not run tests against D10 because it has Composer require-dev dependencies of other Drupal modules (layout_library, dashboards, mini_layouts) that aren't Drupal 10 compatible themselves.
I removed the tests and test dependencies related to those modules and ran the rest of the test suite locally with D10, and everything passed. Woohoo!
I think the best thing to do would be to let this issue hang out for a bit while we work on getting layout_library, dashboards, and mini_layouts D10 compatible (I should have some capacity to do this in the coming weeks). Once those are compatible, in theory all of the Layout Builder Restrictions tests should pass and we can merge this.
How does that sound? (Marking this as "Postponed" presumptively.)
Comment #12
eiriksmGreat plan. Great work! 💪🤩
Comment #13
mark_fullmerOkay, I've submitted code for D10 compatibility for both layout_library and mini_layouts, and set to "Needs Review"
- https://www.drupal.org/project/layout_library/issues/3288245
- https://www.drupal.org/project/mini_layouts/issues/3296076
Once those are merged, we can return to this.
Comment #14
kristen polThanks for working on this issue!
Adding related issue, tagging, and showing dependencies so we can see status here:
#3288245: Drupal 10 compatibility
#3296076: Drupal 10 compatibility
Comment #15
kristen polThe layout_library patch has been committed but we are still waiting on testing/merging for mini_layouts.
Comment #16
mark_fullmerThanks for keeping tabs on this!
Comment #17
mark_fullmerFollowing phenaproxima's suggestion to skip test coverage on mini_layouts for the time being (https://www.drupal.org/project/mini_layouts/issues/3296076#comment-14778975), I'm un-postponing(!) this and will update the MR with the relevant changes so we can get a D10-compatible release out the door! (Unless anyone objects...)
Comment #18
phenaproximaDrupal 10 compatibility has landed in mini_layouts, but in a new major branch (2.0.x).
So, my suggestion on how to proceed here: make the integration tests optional, and also adjust the require-dev constraints to use the new branch of mini_layouts. Everybody wins!
Comment #19
mark_fullmerComment #20
mark_fullmerTests pass on D9 and D10, including integration tests for Dashboards, Mini Layouts, and Layout Library! I think we're good here.
Comment #21
phenaproximaOne question, but no objections from me.
Comment #23
mark_fullmerMerged, tagged, and released! https://www.drupal.org/project/layout_builder_restrictions/releases/8.x-...
Comment #24
kristen polThanks!