Problem/Motivation

Moving files between two different stream wrappers isn't always possible or ideal. For example, imagine two S3 buckets, one with the s3a:// and another with s3b:// stream wrapper scheme. Using s3a://tmp as the temporary location and s3b://file/[file:fid] as the permanent location could result in file movement errors between the two S3 buckets.

Proposed resolution

Allow temp_location config to be overridden on a per-field basis.

CommentFileSizeAuthor
#9 3257811-9-temp-location-override.patch4.06 KBb_sharpe
#8 3257811-2718783-8-temp-location-override.patch3.58 KBbobooon
#7 3257811-2718783-7-temp-location-override.patch.patch3.59 KBbobooon
#7 3257811-7-temp-location-override.patch3.43 KBbobooon
#4 3257811-COMBINED-2718783-temp-location-override.patch3.49 KBb_sharpe
#4 interdiff.txt321 bytesb_sharpe
#4 3257811-4-temp-location-override.patch3.39 KBb_sharpe
#3 3257811-3-temp-location-override.patch3.49 KBbobooon
#2 3257811-2-temp-location-override.patch3.39 KBbobooon

Issue fork filefield_paths-3257811

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robphillips created an issue. See original summary.

bobooon’s picture

bobooon commented
Status: Active » Needs review
StatusFileSize
new 3257811-2-temp-location-override.patch3.39 KB
bobooon’s picture

bobooon commented
StatusFileSize
new 3257811-3-temp-location-override.patch3.49 KB

Use #2 against non-patched 8.x-1.x. Use #3 if using patch from #2718783: Call to undefined method BaseFieldDefinition::getThirdPartySettings().

b_sharpe’s picture

b_sharpe commented
StatusFileSize
new 3257811-4-temp-location-override.patch3.39 KB
new interdiff.txt321 bytes
new 3257811-COMBINED-2718783-temp-location-override.patch3.49 KB

Fixes Undefined index "temp_location" from above. Patch 4 + interdiff. Patch combined also for 2718783.

The last submitted patch, 4: 3257811-4-temp-location-override.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 4: 3257811-4-temp-location-override.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bobooon’s picture

bobooon commented
StatusFileSize
new 3257811-7-temp-location-override.patch3.43 KB
new 3257811-2718783-7-temp-location-override.patch.patch3.59 KB

Fixed undefined index warning.

bobooon’s picture

bobooon commented
StatusFileSize
new 3257811-2718783-8-temp-location-override.patch3.58 KB
b_sharpe’s picture

b_sharpe commented
StatusFileSize
new 3257811-9-temp-location-override.patch4.06 KB

Now that #2718783: Call to undefined method BaseFieldDefinition::getThirdPartySettings() has been fixed, rerolling based on 1.x

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs review » Needs work

Nice feature. Please prepare a MR and add test coverage.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Priority: Normal » Major

b_sharpe changed the visibility of the branch 3257811-tmp-path to hidden.

b_sharpe opened merge request !33

b_sharpe’s picture

b_sharpe commented

Moved to MR, still needs tests.

  • voleger committed d6a261eb on 8.x-1.x authored by b_sharpe 
    feat: #3257811 Override temp_location in field configuration
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs work » Fixed

Added test and merged in. Thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.