Problem/Motivation

There are some deprecated functions (will be removed in Drupal 10) on libraries/tests/src/Functional/LibrariesWebTest.php

Steps to reproduce

Open LibrariesWebTest.php with a IDE that recognizes deprecated code (as vscode for e.g.) and you'll be able to see the deprecated functions.

Proposed resolution

Replace the deprecated functions

Remaining tasks

Replace the deprecated functions
Create and send a patch
Review the patch

CommentFileSizeAuthor
#3 3256985-3.patch17.22 KBandregp

Issue fork libraries-3256985

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andregp created an issue. See original summary.

andregp’s picture

andregp commented

I'm working on a patch for this issue.

andregp’s picture

andregp commented
Assigned: andregp » Unassigned
Status: Active » Needs review
StatusFileSize
new 3256985-3.patch17.22 KB

Found 3 deprecated functions (verbose(), assertRaw(), assertNoRaw()) on several places and replaced them based on this documentation https://www.drupal.org/node/3197514 https://www.drupal.org/node/3129738

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues

I'll review it.

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned

Patch applies to me. Although, I suggest that the issues' title changes to something more specific, once that not all the deprecation messages are being resolved in that patch. (And the issue summary too.)

Matheus Macario’s picture

Matheus Macario commented
Assigned: Unassigned » Matheus Macario
Matheus Macario’s picture

Matheus Macario commented
Assigned: Matheus Macario » Unassigned
Status: Needs review » Reviewed & tested by the community

So, after have done the code review on the #3 patch, i noticed that there are no more deprecated functions as @andregp mentioned before, the 3256985-3.patch fix those problems in the LibrariesWebTest.php file , with that been said i'm changing the status to RTBC.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora opened merge request !12

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Great work, thank you again

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.