Undefined offset _eu_cookie_compliance_remove_script_from_loader

Hi Martijn! Thanks for the report.

Do you keep seeing this notice after the update has completed?
It seems that the function got some unexpected input, but it's not clear from the report what was the input.

Thanks, that was helpful information. I'll take a look at this in the weekend.

We have experiencing this issue too.

Notice: Undefined offset: 0 in _eu_cookie_compliance_remove_script_from_loader() (riadok 858 from /xxx/sites/all/modules/eu_cookie_compliance/eu_cookie_compliance.module).
Notice: Undefined index: scope v drupal_get_js() (riadok 4472 z /xxx/includes/common.inc).

To workaround this I think that update.php needs to be considered as an admin page by default. So we need to change this to fix the problem:

  if (!empty($popup_settings['exclude_admin_pages']) && path_is_admin($current_path)) {
    $path_is_excluded = TRUE;
  }

To something like this (devel has the same strstr() condition):

  if ((!empty($popup_settings['exclude_admin_pages']) && path_is_admin($current_path)) || strstr($_SERVER['PHP_SELF'], 'update.php')) {
    $path_is_excluded = TRUE;
  }

After this the notices are gone.

Well it seems like that this problems does not only affect update.php, but also other "system" calls like system/ajax and similar, which gives this undefined error. So my propsal to add update.php to that condition was not enough.

We are now using this patch.

The function _eu_cookie_compliance_get_script_key() will return FALSE if the script is not found, but this was not taken into account while calling _eu_cookie_compliance_remove_script_from_loader() function. The patch will ensure that the function will not be called if the script was not found (so no script can be modified anyway).

Can you test this patch if it will work for you?