Problem/Motivation

In https://www.drupal.org/project/bs_base/issues/3008285#comment-14112148 rules for resetting input radius on left or right side are added when input element has input group prefix or suffix. When floating labels are enabled we are always adding `input-group-label` CSS class and we should add it only when prefix or suffix exist. As a result of this left or right border radius of input element can be reset.

CommentFileSizeAuthor
#2 floating-label-input-radius-reset-3256688-2.patch1.9 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Title: Floating labels input-group-label CSS class always added resulting in input border radius reset » Floating labels input has left or right border radius reset
Status: Active » Needs review
StatusFileSize
new floating-label-input-radius-reset-3256688-2.patch1.9 KB

Actually we need that div.input-group-label wrapper because we are using it to position floating label so that needs to stay. The solution is simple we just need to modify selector for that rules so it is active only when `input-group` wrapper element exist which means that prefix or suffix is set.

  • pivica committed 52b654b on 8.x-1.x 
    Issue #3256688 by pivica: Floating labels input has left or right border...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.