Found a PHPdoc issue in update.authorize.inc.

update_authorize_run_install() and update_authorize_batch_copy_project() hint an argument as (unqualified) FileTransfer instead of (FQN) \Drupal\Core\FileTransfer\FileTransfer. This may have escaped type-checking in IDE so far, because the functions are only ever called indirectly via callback.

CommentFileSizeAuthor
#2 3256581.patch1.1 KBcburschka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cburschka created an issue. See original summary.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Status: Active » Needs review
FileSize
3256581.patch1.1 KB
init90’s picture

init90
Location Ukraine
CreditAttribution: init90 at ZANZARRA Drupal Agency, Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: +Documentation

  • catch committed 1670eac on 10.0.x 
    Issue #3256581 by cburschka: PHPdoc in update.authorize.inc
  • catch committed b00f273 on 9.4.x
    Issue #3256581 by cburschka: PHPdoc in update.authorize.inc

(cherry...

  • catch committed 7ef26e6 on 9.3.x 
    Issue #3256581 by cburschka: PHPdoc in update.authorize.inc

(cherry...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 10.0.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x/9.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.