Problem/Motivation

D10 deprecated code needs removal in D11.

Proposed resolution

Remove deprecated code, legacy tests, PHPStan baselined errors.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3256524

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: #3210310: Adjust Database API to remove deprecated Drupal 9 code in Drupal 10 »
mondrake’s picture

mondrake
Location 🇮🇹
commented
Version: 10.0.x-dev » 11.0.x-dev
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Adjust Database API to remove deprecated Drupal 10 code in Drupal 11 » [11.x] Adjust Database API to remove deprecated Drupal 10 code in Drupal 11
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

mondrake opened merge request !4732

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: Unassigned » mondrake
Status: Postponed » Needs work

Time to reopen this.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

+115 −4560 that's quite a cleanup!

A number of classes were forcibly created during D10 cycle just to support deprecations (example, Drupal\mysql\Driver\Database\mysql\Select). However I do not think we can just remove them, custom/contrib may have extended from them instead from the base classes. So I deprecated them here if they're not overriding anything.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Opened a Meta to start tracking deprecation removals

This one I feel was perfectly scoped. I checked the core/lib/database folder searching for deprecation and all instances have been removed.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +PHPUnit 10

This is relevant for the PHPUnit 10 upgrade, since it removes a call to trigger_error(…, E_USER_WARNING).

daffie’s picture

daffie commented

+1 for RTBC.

This really cleans up the Database layer and the drivers a LOT!!!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
+ 115
− 4586

!!!!

Looks great to me, but needs a rebase.

mondrake’s picture

mondrake
Location 🇮🇹
commented

rebased

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

All dbs green.

  • catch committed 6490db80 on 11.x 
    Issue #3256524 by mondrake: [11.x] Adjust Database API to remove...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

mondrake closed merge request !4732

smustgrave’s picture

smustgrave commented
Parent issue: » #3295574: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch

Consolidating metas

solideogloria’s picture

solideogloria commented

Nice! 🎉

mondrake’s picture

mondrake
Location 🇮🇹
commented

This has likely broken drush site-install, I filed https://github.com/drush-ops/drush/issues/5882

I think the fix should happen in Drush now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Version: 11.x-dev » 11.0.x-dev

Update version to the branch this applies to.