Problem/Motivation

Migrate r4032login configuration from Drupal 7 site to Drupal 9.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 r4032login_migration_3256084-7.patch9.13 KBsrishtiiee
#6 interdiff_4-6.txt688 bytessrishtiiee
#6 r4032login_migration_3256084-6.patch9.12 KBsrishtiiee
#4 interdiff_2-4.txt843 bytessrishtiiee
#4 r403login_migration_3256084-4.patch9.08 KBsrishtiiee
#2 r4032login_migration_3256084-2.patch9.04 KBsrishtiiee

Comments

srishti.bankar created an issue. See original summary.

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
StatusFileSize
new r4032login_migration_3256084-2.patch9.04 KB
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Needs work

Tested manually and data is migrated properly.
Some suggestions:

  1. +++ b/src/Plugin/migrate/process/R4032loginPath.php
@@ -0,0 +1,30 @@
+ * Maps D7 r4032login settings to D9.

    Maps D7 r4032login settings to D9 => Maps D7 r4032login path settings to D9 

  2. +++ b/src/Plugin/migrate/process/R4032loginPath.php
@@ -0,0 +1,30 @@
+    foreach (explode("\r\n", $value) as $path) {
+      $all_paths = $all_paths . '/' . $path . "\n";
+    }

    $path can be checked if it is empty or not to avoid extra new lines migration

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
StatusFileSize
new r403login_migration_3256084-4.patch9.08 KB
new interdiff_2-4.txt843 bytes

Addressed #3.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Needs work 
+++ b/src/Plugin/migrate/process/R4032loginPath.php
@@ -0,0 +1,32 @@
+      if (rtrim($path)) {
+        $all_paths = $all_paths . '/' . $path . "\n";
+      }

Can be replaced with 

      $trimmed_path = trim($path);
      if ($trimmed_path) {
        $all_paths = $all_paths . '/' . $trimmed_path . "\n";
      }
srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
StatusFileSize
new r4032login_migration_3256084-6.patch9.12 KB
new interdiff_4-6.txt688 bytes
srishtiiee’s picture

srishtiiee commented
StatusFileSize
new r4032login_migration_3256084-7.patch9.13 KB
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Configurations are migrated from D7 to D9. Tested manually. 👍

nixou’s picture

nixou commented
Status: Reviewed & tested by the community » Fixed

Awesome ! Thank you very much.

Committed to 2.x-dev, will be released in 2.1.1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.