Olivero: tour module popup close button size issue

I'll work on this issue

Here's a simple patch to solve this issue.

Fixing coding standards.

I keep getting the error No files matching the pattern "/var/www/html/core/themes/olivero/css/components/tour.css" were found. on the tests above (#3 and #4). So instead of creating a new file for the custom style, I just added it to a file that already exists.

(I'm not providing an interdiff as it's a completely different approach.)

@ranjith_kumar_k_u the olivero.libraries.yml only loads the button.css file not the button.pcss.css so why did you change it too on your patch? What does you patch do differently from the previous one?
When providing a new patch It's a good practice to explain the reason so the community can know what you're trying to fix.

@andregp I thought that the pss.css files were used to generate the .css files which is why the:

/*
 * DO NOT EDIT THIS FILE.
 * See the following change record for more information,
 * https://www.drupal.org/node/3084859
 * @preserve
 */

is at the top of the .css files. No? But, I haven't done much frontend dev in a long time and have only worked with Sass/Less before.

Tagging for testing since tests are passing.

Patch applies cleaning to Drupal 9.3 and 9.4 and with offsets for Drupal 10:

[drupal-10.0.x-dev/10.0.x] [drupal-10.0.x-dev]$ patch -p1 < 3256003-6.patch 
patching file core/themes/olivero/css/components/button.css
Hunk #1 succeeded at 202 (offset 13 lines).
patching file core/themes/olivero/css/components/button.pcss.css

Added testing notes. Also tagging for the issue summary to be cleaned up such as using the issue summary template.

Hi @Kristen Pol,

Verified with Patch #6
Version - 9.4
Theme - Olivero
Testing result : Now Close button is bigger and more similar to the Umami Demo theme size.

Note : Patch file is not working on 9.3

Thanks for testing @Satyajit1990. You don't have to include files of simplytest.me or DrupalPod not working.

But, I have found out from @catch that when the patch applies to more than one version, we can just test on 9.4 or 10, i.e. we don't have to test on all versions... just ones with different MRs/patches.

Assuming this CSS approach is okay, all that's needed is the issue summary update.

Updated the issue summary to use the template. Marking RTBC based on the above.

Committed c606891 and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!