Problem/Motivation
When logged in as a user without 'administer feeds' permission, but with access to 'access feed overview', and viewing the page at /admin/content/feed (with Views module installed), the user is not currently able to see anything under the "Type" column, which is not great for their user experience navigating that page.
Steps to reproduce
- Clean install of Drupal 9.x
- Install Feeds 8.x-3.x
- Install Views if not already installed
- Create a new feed type
- Create a role (and user) who has the permission 'access feed overview' and 'view x feeds' (where x is the feed type you created in the previous step)
- Create at least one feed of your new feed type
- Navigate to /admin/content/feed
Proposed resolution
It's not perfect, but arguably if the user has permission to view feeds of that type, they should be able to see the feed type in the 'Type' column. This could use a bit more thinking but I wanted to at least share the patch that we are using in case anyone else ends up in a similar situation.
It should be noted that with the default config of the view, the user will get a 403 if they try to click on the feed type since they don't have access to that in this scenario.
Remaining tasks
To be determined
User interface changes
I don't think this would really be a UI change.
API changes
n/a
Data model changes
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff-feeds-3255551-2-5.txt | 1.93 KB | star-szr |
| #5 | feeds-3255551-5.patch | 3.17 KB | star-szr |
| #4 | feeds-3255551-3-listing.png | 52.38 KB | star-szr |
| #2 | feeds-3255551-2-after.png | 129.66 KB | star-szr |
| #2 | feeds-3255551-2-before.png | 122.64 KB | star-szr |
Issue fork feeds-3255551
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
star-szrHere is a patch, and before/after screenshots.
Before patch:
After patch:
Comment #4
star-szrFor comparison, here is the non-Views version of the same listing. Maybe a compromise could be to uncheck "Link label to the referenced entity" in the default views config.
Comment #5
star-szrThis should fix up the tests and lint.
Comment #6
irinaz commentedComment #7
irinaz commentedComment #8
irinaz commentedComment #9
irinaz commentedWorks for me. Here is stapshot from testing instance with DrupalPod if anyone wants to see results. https://gitpod.io#snapshot/b087c0d4-8ef8-4ba6-832d-7d8cfd1e772e
Comment #10
megachrizThanks for the patch! I think that unchecking "Link label to the referenced entity" in the default views config is a good compromise. On the admin content listing (/admin/content), the content type doesn't link either. Fixed that on commit.
Comment #12
star-szrThanks @MegaChriz and @irinaz! :D