Problem/Motivation

When logged in as a user without 'administer feeds' permission, but with access to 'access feed overview', and viewing the page at /admin/content/feed (with Views module installed), the user is not currently able to see anything under the "Type" column, which is not great for their user experience navigating that page.

Steps to reproduce

  1. Clean install of Drupal 9.x
  2. Install Feeds 8.x-3.x
  3. Install Views if not already installed
  4. Create a new feed type
  5. Create a role (and user) who has the permission 'access feed overview' and 'view x feeds' (where x is the feed type you created in the previous step)
  6. Create at least one feed of your new feed type
  7. Navigate to /admin/content/feed

Proposed resolution

It's not perfect, but arguably if the user has permission to view feeds of that type, they should be able to see the feed type in the 'Type' column. This could use a bit more thinking but I wanted to at least share the patch that we are using in case anyone else ends up in a similar situation.

It should be noted that with the default config of the view, the user will get a 403 if they try to click on the feed type since they don't have access to that in this scenario.

Remaining tasks

To be determined

User interface changes

I don't think this would really be a UI change.

API changes

n/a

Data model changes

n/a

Issue fork feeds-3255551

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Cottser created an issue. See original summary.

star-szr’s picture

Title: Users with 'access feed overview' and without 'administer feeds' unable to see feeds type on feed listing (Views listing) » Users with 'access feed overview' and without 'administer feeds' unable to see feed type on /admin/content/feed (Views listing)
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.08 KB
new122.64 KB
new129.66 KB

Here is a patch, and before/after screenshots.

Before patch:

Nothing in 'Type' column

After patch:

Displaying feed type in 'Type' column

Status: Needs review » Needs work

The last submitted patch, 2: feeds-3255551-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

star-szr’s picture

StatusFileSize
new52.38 KB

For comparison, here is the non-Views version of the same listing. Maybe a compromise could be to uncheck "Link label to the referenced entity" in the default views config.

Native (non-Views) listing of feeds showing feed type in 'Type' column

star-szr’s picture

Status: Needs work » Needs review
StatusFileSize
new3.17 KB
new1.93 KB

This should fix up the tests and lint.

irinaz’s picture

Issue tags: +GlobalSprint2021
irinaz’s picture

Issue tags: -GlobalSprint2021 +GlobalSprint2022
irinaz’s picture

Issue tags: -GlobalSprint2022 +ContributionWeekend2022
irinaz’s picture

Status: Needs review » Reviewed & tested by the community

Works for me. Here is stapshot from testing instance with DrupalPod if anyone wants to see results. https://gitpod.io#snapshot/b087c0d4-8ef8-4ba6-832d-7d8cfd1e772e

megachriz’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the patch! I think that unchecking "Link label to the referenced entity" in the default views config is a good compromise. On the admin content listing (/admin/content), the content type doesn't link either. Fixed that on commit.

  • MegaChriz committed a1f5d49 on 8.x-3.x authored by Cottser
    Issue #3255551 by Cottser, irinaz, MegaChriz: Allow users with 'access...
star-szr’s picture

Thanks @MegaChriz and @irinaz! :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.