Update composer.json

CommentFileSizeAuthor
#7 support-externalauth2-7.patch1.28 KBslasher13
#5 support-externalauth2-5.patch1.24 KBslasher13
#3 support-externalauth2-3.patch1.79 KBslasher13
support-externalauth2.patch373 bytesslasher13

Comments

slasher13 created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, support-externalauth2.patch, failed testing. View results

slasher13’s picture

slasher13
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new support-externalauth2-3.patch1.79 KB

fix tests

Status: Needs review » Needs work

The last submitted patch, 3: support-externalauth2-3.patch, failed testing. View results

slasher13’s picture

slasher13
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new support-externalauth2-5.patch1.24 KB

fix tests

Status: Needs review » Needs work

The last submitted patch, 5: support-externalauth2-5.patch, failed testing. View results

slasher13’s picture

slasher13
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new support-externalauth2-7.patch1.28 KB

fix tests

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work 
  1. +++ b/composer.json
@@ -11,8 +11,8 @@
-    "php": ">=7.1.0",
+    "php": ">=7.4.0",

    I don't see why the added tests suddenly add a minimum PHP requirement of PHP 7.4.. Please don't do changes just because they look cool. Even if those lines do indeed break on PHP 7.3, I'd rather remove them than make the module incompatible with a lot of installs out there. 

  2. +++ b/composer.json
@@ -11,8 +11,8 @@
-    "drupal/externalauth": "^1.3"
+    "drupal/externalauth": "^1.3 | ^2.0"

    I should never have added this to composer.json. This is already managed more than fine by the drupal.org packagist through the information in the info.yml. Let's delete this line and let drupal.org handle this.

  • jcnventura committed 1b390df on 2.x 
    Issue #3255394 by slasher13, jcnventura: Support externalauth 2
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.