[SUPPORT] CKEditor5

IIRC this bug was fixed months ago, I forget if that was on the Drupal side (downstream) or on the CKE5 side (upstream):

Can you test this again, with the latest Drupal 9.3 patch release? 🙏

RE: dark mode: a quick search led me to https://github.com/ckeditor/ckeditor5/issues/8275, which in turn led me to https://ckeditor.com/docs/ckeditor5/latest/examples/framework/theme-cust... — look at that! 🤩🥳

Although it was designed with versatility and the most common editor use cases in mind, some integrations may require adjustments to make it match the style guidelines of the ecosystem. This kind of customization can be done by importing an extra .css file and overriding the native CSS variables.

Doesn't that sound wonderful? :D

There's still a z-index issue when scrolling a text area out of the viewport while having the heading dropdown open.

The default size of an empty text area is also quite small, not sure if this is a Gin issue.

CKEditor 5 support with proper Darkmode integration is ready for testing! 🥳

Very nice! And with surprisingly little code! :D

The most recent CKEditor 5 update (#3306153: Update CKEditor 5 to 35.1.0) incorporated a huge amount of work (done upstream!) to ensure sufficient contrast. It was required for #3283803: [upstream] CKE5 toggleable toolbar items not enough contrast. It'd be a shame if this regressed on that front 🤓

@wimleers this has been addressed 👍

Still looking for a review here

Just tested this with the code from the MR in a site running Drupal 9.4.8 with CKEditor 5 enabled.
Looks good to me!

Contrast

Darkmode

@Johan den Hollander I fixed 2 small visual bugs for the highlighted item background and the icon color in the latest ckeditor5 version.

Allright. Updated core to use the latest 9.4.x dev version.
Also saw Gin updating to a later commit:
- Upgrading drupal/gin (dev-3255204-support-ckeditor5 59a412d => dev-3255204-support-ckeditor5 7fe65ee)

Had to do some intense staring on the provided screenshots but could make out the differences.
Look like it's the same now:

This looks very solid to me 🤩

Love that you're feeding --gin-SOMETHING into --ck-SOMETHING — impressive reuse & extensibility! 🤓

I don't think this should be blocked on accessibility review — even if it's maybe less optimal, this clearly is a step in the right direction, we shouldn't block contrib themes on the strict gates that core needs to comply with. Pragmatic progress matters more!

Had to do some intense staring on the provided screenshots

🤣👏

Love that you're feeding --gin-SOMETHING into --ck-SOMETHING — impressive reuse & extensibility! 🤓

Yeah the fact that CK5 also uses CSS3 vars made this waaaay easier. Only minimal overrides were needed.

#3314541: Remove unnecessary fill from SVG icon for the "Media Library" CKEditor 5 button — enabling dark mode support in contrib landed! 🚀

Thanks all for making this a reality!