The function check_output() has been renamed to check_markup() in HEAD.
See http://drupal.org/node/22218 for details.

Attached is a simple patch to sidecontent.module so that it uses the new API
while retaining backwards compatibility with 4.6.3.

Comments

Tobias Maier’s picture

I think it is better if you would just release a patch compatible to CVS HEAD.
Else all the modules get more and more messy

this patch could for example just be in the HEAD-branch and the 4.6-branch will stay as it is.

cya tobias

Richard Archer’s picture

StatusFileSize
new859 bytes

Here's a simplified patch which is only compatible with HEAD/4.7.0.

robert castelo’s picture

Thanks, I'll try out this patch when I update all my modules for 4.7 - which should be soon.

kvarnelis’s picture

tried this on 4.7 beta. couldn't get it to work.

kvarnelis’s picture

ok, managed to get it to work. error on my part. so anybody who's playing with it in 4.7 can rest assured that it does work!

marknewlyn’s picture

Hi

How did you get this to work? I downloaded and installed sidecontent from cvs on my 4.7.0-beta2 site - applied the patch but there is nothing under settings? Is there another patch somewhere that updates everything else to make it work?

Mark

Robin Jastrzebski’s picture

StatusFileSize
new4.26 KB

Apparently the trouble is with the new forms API in 4.7, which breaks compatibility. I've hacked away a bit and changed to code to make use of the new forms stuff... this seems to work for me on beta4. Patch is included, which incorporates Richard's code. I've removed the old form handlers for the sake of clarity, so this should only be used with 4.7.*.

kvarnelis’s picture

Title: Sidecontent fails in HEAD/4.7.0 » sidecontent failing under 4.7b4

i've had some weird problems with sidecontent under 4.7b4

i installed it using the newest patch (see below for a problem i made) (yes, i did the mysql install) and was surprised that all of my settings for blocks (not sidecontent blocks) had to be redone (basically i had to go in and save to get them to appear on the right pages, not change anything, just resave). ok, i did that.

i created some sidecontent and it didn't appear even after the block was enabled, but i had barely tested it. i looked for the access control setting and couldn't find it. in debugging it, i realized the sidecontent directory was accidentally uploaded to the pathauto direcctory. ok, fine, i moved it to modules.

here is where everything went downhill. the module now still appears under modules and it is enabled, but it doesn't appear in access control and also doesn't appear under blocks anymore. sidecontent is missing in action.

any thoughts? !!

kvarnelis’s picture

Title: sidecontent failing under 4.7b4 » sidecontent failing under 4.7b5

i'm trying to use the supplied patch under beta 5.

sidecontent seems to work, but the radio buttons in input format for entries wind up blank! setting them does no good.

this is confirmed on a clean install of beta 5 running nothing but sidecontent.

deekayen’s picture

Status: Needs review » Fixed

Testing the patch with latest CVS works. Committed to HEAD and branched for DRUPAL-4-7. I also added a check so if the admin turns off sidecontent for a node type, the block checks to see if it should display the type or not, whether content is there or not.

deekayen’s picture

Status: Fixed » Needs review

I got in trouble for committing this, so it's been reverted and unbranched. See CVS revision 1.6 for what I had committed.

http://cvs.drupal.org/viewcvs/drupal/contributions/modules/sidecontent/s...

jamin’s picture

I'm using 4.7, and applied the sidecontent-4.7.0-beta4.patch to get Side Content working. Everything works great, except that changing the Input format does not update the format field in the DB.

If I go into the DB and change the format manually, it displays correctly. So it's reading the field fine. It just won't update.

angelahoistion’s picture

Title: sidecontent failing under 4.7b5 » sidecontent failing under 4.7
Version: master » 4.6.x-1.x-dev

I applied the patch but nothing changed (side content is not working)...any ideas to help??

marcoBauli’s picture

Version: 4.6.x-1.x-dev » master

Hi there, just to add a cent to this:

sidecontent 1.7 seems to work fine for me on 4.7 :)

1.8 (that should same as 1.5) fails, giving following error when trying to configuring the block:

Fatal error: Call to undefined function: form_textfield() in /home/kiteatla/public_html/drupal/sites/test-site/test/modules/sidecontent/sidecontent.module on line 63

PS: consider that a conflict with the Node(key)words module has been resolved in the latter's last release.

robert castelo’s picture

Status: Needs review » Fixed

cvs version is now for 4.7, and I'll create a 4.7 branch next weekend if there are no show stopping bugs.

Thanks for everyones work on these patches, I've incorporated the best bits of them into the new release.

I haven't had time to test updating from a 4.6 version to 4.7, so would be very useful if anyone could let me know their experiences with updating. This also means you really MUST backup your database before updating.

Note that the block configuration form now has a few new options for how sidecontent fields are displayed on the node form.

Lastly, anyone wants to add to the README.txt documentation, that would be very welcome :-)

Anonymous’s picture

Status: Fixed » Closed (fixed)