Problem/Motivation

In #3254207: Only allow 1 patch release update increment in Cron we found out that we need a method in UpdateRecommender to recommend release during cron because in the form it’s better to recommend the most recent patch to the installed minor.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3254755

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kunal.sachdev created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

#3252190: Store all installable releases in update_calculate_project_update_status() would make it possible for use to always recommend the latest in the current minor.

but even before then if the update recommends a version in the next minor we can check if there is security release in the current minor.

This would mean that before we have 3252190 then a site could update via composer to keep there site on the latest patch releases but if I security release happen cron would update to it.

kunal.sachdev opened merge request !204

tedbow opened merge request !207

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » tedbow

I am in middle of work on this

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Add method to UpdateRecommender to recommend release during cron. » Add a seperate Update recommender and update version validator for cron updates
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +beta blocker

tedbow opened merge request !228

phenaproxima made their first commit to this issue’s fork.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » phenaproxima
Status: Active » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Whew. There are some small things I'd like to clean up, but this is already a major refactoring of some important parts of the system, and I think it's gone on long enough. I'm happy overall with what @tedbow and I cooked up here. RTBC!

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

  • tedbow committed 2487d9c on 8.x-2.x 
    Issue #3254755 by tedbow, kunal.sachdev, phenaproxima: Add a seperate...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed

🥳

@phenaproxima thanks for sticking with this one!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.