Problem/Motivation

Since I upgraded to Drupal 9.3 the Drupal Icon is back as Favicon.
The Metatag is still placed by this module like it should but for some reason the favicon of Drupal is fetched instead of the one given by my path in Metatag.

CommentFileSizeAuthor
#7 metatag-3253736-icon-drupal93-regression.diff2.39 KBdave reid

Issue fork metatag-3253736

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zebda created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Favicon not shown » Regression with favicon metatag with Drupal 9.3
Version: 8.x-1.16 » 8.x-1.x-dev
Related issues: +#3195222: Incorrect favicon rel attribute value - shortcut

I believe this is a result of https://www.drupal.org/node/3220042 and core issue #3195222: Incorrect favicon rel attribute value - shortcut

Dave Reid opened merge request !38

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I don't see the Drupal 9.3 tests with any regressions (they currently have 4 failures on the dev branch as well), so I think this is ready.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Regression with favicon metatag with Drupal 9.3 » favicon meta tag was renamed in Drupal 9.3.0
Status: Needs review » Reviewed & tested by the community
Parent issue: » #3203686: Plan for Metatag 8.x-1.17
Related issues: +#3252159: Fix tests compatibility with Drupal 9.3.x

Looks good, thanks for putting this together.

FYI there's another issue for dealing with the 9.3.x test coverage: #3252159

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new metatag-3253736-icon-drupal93-regression.diff2.39 KB

Uploading a static version of the MR for use with composer-patches.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks Dave!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
zebda’s picture

zebda commented

Works perfectly thanks a lot!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.