The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.
The SettingsForm and the ConfigSubscriber classes aren't supposed to be extended by other classes. They should be marked as interrnal, with a comment saying that in future they could be marked as final.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3253474-7.patch | 858 bytes | andregp |
Comments
Comment #2
avpadernoComment #3
andregp commentedI'll work on it.
Comment #4
andregp commentedDone.
Comment #5
avpadernoThank you for the patch!
The comment needs to be on a new line, indented by two spaces.
Comment #6
andregp commentedOkay, I'll do it then :)
Comment #7
andregp commentedHere is the new patch and a draft of the record's change https://www.drupal.org/node/3254150
Comment #8
Matheus Macario commentedComment #9
Matheus Macario commentedI did the review and these were the steps performed :
- Installed module
- Applied the 3253474-7.patch
- Code review on changes
- reviewed again, and nothing wrong was found. All according to standards
Comment #12
avpadernoI committed the patch to both the branches. Thank you for the patch!