Problem/Motivation

Thank you for your contribution, it's great module!
I worked with Logs HTTP module it has a useful configuration minimum severity level to choose starting from which severity level log events.
Sometimes no need to log all events like debug or info.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 log_stdout-add_min_severity_level_config-3253402-1.patch3.92 KBberramou

Issue fork log_stdout-3253402

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berramou created an issue. See original summary.

berramou’s picture

berramou commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
StatusFileSize
new log_stdout-add_min_severity_level_config-3253402-1.patch3.92 KB
fraserthompson’s picture

fraserthompson
he/him
Location Dunedin, New Zealand
commented

This would be a very useful feature and the patch looks good. Can it be merged?

berramou’s picture

berramou commented
Status: Active » Reviewed & tested by the community
bladedu’s picture

bladedu
he/him
Primary language Italian
Location Italy
commented

Could you please open a Merge Request?

berramou opened merge request !16

  • berramou committed 0f410274 on 8.x-1.x 
    Issue #3253402: Add minimum severity level configuration
berramou’s picture

berramou commented
Status: Reviewed & tested by the community » Fixed
berramou’s picture

berramou commented
Status: Fixed » Closed (fixed)

Closed fixed, since it's already included in the release 3.0.0 !

berramou’s picture

berramou commented
berramou’s picture

berramou commented
berramou’s picture

berramou commented

Hello,
@bladedu can you give contributors credit on this issue please ?

here is contribution record page https://new.drupal.org/contribution-record/10187850

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Unless I am misreading the code, on an upgraded site, this will result is nothing being logged because the severity_level config will be NULL, which is like zero for this comparison:

if ($level > $this->config->get('severity_level')) {

There is a default set in config/install, but that won't get set for an upgrade.

smaz’s picture

smaz
Primary language English
Location England, UK
commented

Added a followup for #13:

https://www.drupal.org/project/log_stdout/issues/3597159