Problem/Motivation

On active, tab menu color is not correct, it is not visible.

Steps to reproduce

  • Install the theme
  • Create any content or article
  • Go to that node
  • The text of the menu is not visible when the tab menu is active.
  • See SS for more clarity

Proposed resolution

Need to change the tab menu color on active state.

CommentFileSizeAuthor
#11 3253215-11-after.png7.46 KBshyam_bhatt
#11 3253215-11-before.png6.78 KBshyam_bhatt
#10 interdiff_[7]-[10].txt68.24 KBanoopsingh92
#7 bulma-theme-active-menu-issue.png143.35 KBanoopsingh92
#7 On_active_tab_menu_color_is_not_correct-3253215-6.patch67.59 KBanoopsingh92
#2 tab-issue.png8.54 KBrakhi soni
#2 On_active_tab_menu_color_is_not_correct-3253215-2.patch518 bytesrakhi soni
Screenshot_10.png102.28 KBshweta__sharma

Issue fork bulma-3253215

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shweta__sharma created an issue. See original summary.

rakhi soni’s picture

rakhi soni commented
Assigned: Unassigned » rakhi soni
Status: Active » Needs review
StatusFileSize
new On_active_tab_menu_color_is_not_correct-3253215-2.patch518 bytes
new tab-issue.png8.54 KB

tab-color-issue
I have created a patch to fix the issue of "On active, tab menu color is not correct".

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for submitting the patch.

It looks from this issue on the Bulma framework that the issue may be solved in the latest version. Before applying a fix, we should test updating.

rakhi soni’s picture

rakhi soni commented
Assigned: rakhi soni » Unassigned

anoopsingh92 made their first commit to this issue’s fork.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: Unassigned » anoopsingh92
Status: Needs review » Needs work

Hello @Rakhi Soni,

I reviewed your patch. You have made all changes in the CSS file directly but the entire theme is based on SCSS. when you compile this SCSS file your changes will go. That's why we need to work on the SCSS file instead of CSS after compiling changes will be refect on the page automatically.

I am working on it. I will provide you with a patch with the coding standard also.

Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
StatusFileSize
new On_active_tab_menu_color_is_not_correct-3253215-6.patch67.59 KB
new bulma-theme-active-menu-issue.png143.35 KB

Hello,

I am providing a patch with the screenshot. I hope it will help. Please review this patch.

Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Needs work » Needs review
sourabhjain’s picture

sourabhjain
Primary language English
commented

@anoop could you please attach the interdiff file too.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
StatusFileSize
new interdiff_[7]-[10].txt68.24 KB

Hello @sourabhjain, I have attached the interdiff please find it and check. Thanks

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3253215-11-before.png6.78 KB
new 3253215-11-after.png7.46 KB

I have checked the "On_active_tab_menu_color_is_not_correct-3253215-6.patch" patch working fine.
Please check the below images:

Before:
2022-10-14/3253215-11-before.png

After:
2022-10-14/3253215-11-after.png

sourabhjain’s picture

sourabhjain
Primary language English
commented
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Reviewed & tested by the community » Fixed

Tnx all for the effort. But seems this is fixed in Bulma it self https://github.com/jgthms/bulma/issues/3009. Using 0.9.4 version, dont see this issue

valic’s picture

valic
Primary language Croatian
Location Osijek
commented

This seems same problem as here https://www.drupal.org/project/bulma/issues/3253215

But that is fixed in the latest version of Bulma, try using the 0.9.4 version

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.