Problem/Motivation

Drupal 10 is almost on the table at 2022, or has been already in Drupal 9, they said.

Proposed resolution

Identify deprecation, etc.
blazy 10-ready

Remaining tasks

  • [x] Create a D10 test when available: https://www.drupal.org/node/2663268/qa for quick check
  • [x] Update blazy.info.yml 2.x file to add ^10
  • [x] #3254692: Drupal 10, identify deprecation, etc.. Via Drupal-check or Upgrade status, etc. There must be deprecated Twig, or tests.
  • [x] Create a new release with semantic version 3.0.0 as a continuation from 2.x.
  • [x] Create new threads for relevant tasks for easy change tracking and documentation purposes, as needed.

User interface changes

None.

API changes

Not sure, likely none.

Data model changes

Not sure, hopefully none.

Fee free to add more tasks here, and or follow up or provide relevant fixes on separate threads making this as a parent thread.
Thanks.

CommentFileSizeAuthor
#10 blazy--drupal-check--report.txt129.16 KBrajab natshah

Comments

gausarts created an issue. See original summary.

gausarts’s picture

Issue summary: View changes

  • gausarts committed 174d912 on 8.x-2.x
    Issue #3253012 by gausarts: Added Drupal ^10 to track potential...
gausarts’s picture

Issue summary: View changes
gausarts’s picture

Issue summary: View changes

  • gausarts committed ca8bd51 on 8.x-2.x
    Issue #3253012 by gausarts: Added Drupal ^10 to track potential...

  • gausarts committed b31b8d7 on 8.x-2.x
    Issue #3253012 by gausarts: Added Drupal ^10 to track potential...
gausarts’s picture

Issue summary: View changes

Sorry, wrong room commits. Should have gone here: #3254692: Drupal 10, identify deprecation, etc.

gausarts’s picture

Issue summary: View changes
rajab natshah’s picture

StatusFileSize
new129.16 KB

Drupal 10.0 development


Thank you so much for the Drupal Core team

Following with


Further drupal-check on

composer create-project drupal/recommended-project:10.0.0-alpha4@alpha /var/www/html/sandboxes/drupal10blazy

cd /var/www/html/sandboxes/drupal10blazy/

composer config minimum-stability dev

composer require drupal/blazy

composer require drupal/core-dev --with-all-dependencies
composer require mglaman/drupal-check --dev
composer require phpspec/prophecy-phpunit:^2 --dev 

php vendor/bin/drupal-check -d web/modules/contrib/blazy/

Output:

blazy--drupal-check--report.txt


gausarts’s picture

Thank you.

Noted, and we should definitely fix them :)

But I don't understand one thing:
Any reasons I am not aware of why classes which don't belong to Blazy were reported under or as Blazy's errors? IMHO, it adds irrelevant errors that Blazy cannot even touch or fix. A few are core PHP and core Drupal, others are contribs like CSP and Slick.

rajab natshah’s picture

Following on Slick and other used Blazy modules
I will hide the big list of issues. They are attached in the blazy--drupal-check--report.txt file

Thanks, Gaus for having time to work on the blazy group of modules
The more I read about Intersection Observer API the more I see what a nice work put into the module

gausarts’s picture

Got it. Just downloaded your reports for further works.

Patches are welcome if anyone beat me to it. Thanks.

anybody’s picture

Before closing this, what do you think about removing IE related code from a fresh 3.x branch für Drupal 10?

IE support was widely dropped (Google etc.) so we could do the same here with a 3.x for just Drupal 10. And for example entirely remove bLazy fallback for Intersection Observer API (IO) (/admin/config/media/blazy)

What do you think? Separate issue as follow-up then?

gausarts’s picture

> removing IE related code from a fresh 3.x branch
We'll deprecate it at 3.x, and then removed at 4.x. If you don't use it, simply disable it at Blazy UI.

One or two steps behind core, or picking up what was left out by core is what some modules usually do.

Aside I don't want too much more work nor regressions at 3.x. It was planned to remove VEF for core Media, and getting matured, or at least stabilized, a bit after the last dev storms.

anybody’s picture

Thanks @gausarts I think that's a good plan!

  • gausarts committed 0a7fc2d7 on 8.x-2.x
    - Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10.
    - Added...

  • gausarts committed ceaebc6b on 8.x-2.x
    Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
    

  • gausarts committed d00b6d46 on 8.x-2.x
    Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
    

  • gausarts committed 3ff7a2f6 on 8.x-2.x
    Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
    
gausarts’s picture

Status: Active » Postponed

There are few more issues left, mostly related to sub-modules compatibility.

And thus needs pending till 3.x, or future sub-module updates, to avoid disruption. Such as:
Call to an undefined method Drupal\blazy\BlazyManagerInterface::build(). , etc.

Around 70%+ out of 106 errors are not related to Blazy. Mostly the standing issues:

  Line   src/Form/BlazyEntityFormBase.php                            
 ------ ------------------------------------------------------------ 
  111    Call to an undefined method                                 
         Drupal\Core\Entity\EntityInterface::set().    

  Line   tests/src/FunctionalJavascript/BlazyFilterJavaScriptTest.php           
 ------ ----------------------------------------------------------------------- 
  125    Call to an undefined method Drupal\Tests\WebAssert::waitForElement().

  Line   src/Media/BlazyFile.php                             
 ------ ---------------------------------------------------- 
  225    Variable $image in PHPDoc tag @var does not exist.  
  265    Variable $field in PHPDoc tag @var does not exist.  

 ------ ------------------------------------------------------ 
  Line   src/Plugin/Filter/BlazyFilter.php                     
 ------ ------------------------------------------------------ 
  529    Call to an undefined method DOMNode::hasAttribute().  
  530    Call to an undefined method DOMNode::getAttribute().  

  Line   tests/src/Traits/BlazyCreationTestTrait.php (in context of class          
         Drupal\Tests\blazy\Kernel\Views\BlazyViewsTestBase)                       
 ------ -------------------------------------------------------------------------- 
  236    Call to an undefined method                                               
         Drupal\Core\Entity\EntityInterface::get(). 
 ------ -------------------------------------------------------------------------- 
  485    Access to an undefined property                                           
         Drupal\image\Plugin\Field\FieldType\ImageItem::$uri.  

  Line   src/Plugin/Filter/BlazyFilterUtil.php                                     
 ------ -------------------------------------------------------------------------- 
  208    Access to an undefined property DOMNamedNodeMap::$length.    

They are core Drupal or PHP related issues, but unfortunately spit out in the checked modules causing confusions and unfair error counts.
Hopefully they fix them soon.

Until 3.x is released, it is a Postponed.

Thanks.

  • gausarts committed c34c08c0 on 8.x-2.x
    Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
    
gausarts’s picture

Issue summary: View changes
Status: Postponed » Fixed

The last remaining tasks were done.

3.x was just out short after 2.17.

Thank you all contributions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.