Closed (fixed)
Project:
Blazy
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Dec 2021 at 11:32 UTC
Updated:
7 Oct 2023 at 08:24 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
gausarts commentedComment #4
gausarts commentedComment #5
gausarts commentedComment #8
gausarts commentedSorry, wrong room commits. Should have gone here: #3254692: Drupal 10, identify deprecation, etc.
Comment #9
gausarts commentedComment #10
rajab natshahThank you so much for the Drupal Core team
Following with
Drupal 10.0.0 is coming soon. Help us test it today!
Drupal core 10.0.0-alpha4
Released May 06 2022
Further drupal-check on
Comment #11
gausarts commentedThank you.
Noted, and we should definitely fix them :)
But I don't understand one thing:
Any reasons I am not aware of why classes which don't belong to Blazy were reported under or as Blazy's errors? IMHO, it adds irrelevant errors that Blazy cannot even touch or fix. A few are core PHP and core Drupal, others are contribs like CSP and Slick.
Comment #12
rajab natshahFollowing on Slick and other used Blazy modules
I will hide the big list of issues. They are attached in the blazy--drupal-check--report.txt file
Thanks, Gaus for having time to work on the blazy group of modules
The more I read about Intersection Observer API the more I see what a nice work put into the module
Comment #13
gausarts commentedGot it. Just downloaded your reports for further works.
Patches are welcome if anyone beat me to it. Thanks.
Comment #14
anybodyBefore closing this, what do you think about removing IE related code from a fresh 3.x branch für Drupal 10?
IE support was widely dropped (Google etc.) so we could do the same here with a 3.x for just Drupal 10. And for example entirely remove bLazy fallback for Intersection Observer API (IO) (
/admin/config/media/blazy)What do you think? Separate issue as follow-up then?
Comment #15
gausarts commented> removing IE related code from a fresh 3.x branch
We'll deprecate it at 3.x, and then removed at 4.x. If you don't use it, simply disable it at Blazy UI.
One or two steps behind core, or picking up what was left out by core is what some modules usually do.
Aside I don't want too much more work nor regressions at 3.x. It was planned to remove VEF for core Media, and getting matured, or at least stabilized, a bit after the last dev storms.
Comment #16
anybodyThanks @gausarts I think that's a good plan!
Comment #21
gausarts commentedThere are few more issues left, mostly related to sub-modules compatibility.
And thus needs pending till 3.x, or future sub-module updates, to avoid disruption. Such as:
Call to an undefined method Drupal\blazy\BlazyManagerInterface::build()., etc.Around 70%+ out of 106 errors are not related to Blazy. Mostly the standing issues:
They are core Drupal or PHP related issues, but unfortunately spit out in the checked modules causing confusions and unfair error counts.
Hopefully they fix them soon.
Until 3.x is released, it is a Postponed.
Thanks.
Comment #23
gausarts commentedThe last remaining tasks were done.
3.x was just out short after 2.17.
Thank you all contributions.