[D9] CMP Sirdata

HI,
I cloned project and found that README text file dont follow drupal standards

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Hi,
It would great if you can add

MAINTAINERS
-----------

section too.

I do not believe this application can be processed as submitted.

There appear to be no code submissions by the applicant @temlife with the only commits from the applicant being the readme changes requested in #4 and #7. The majority of the repository (including all code) appears to have been written by a different committer.

Additionally the project appears to me to be below the 120 lines code minimum (the form and the .module file) for consideration. Even if the correct applicant applies I am concerned this module may be too short/too simple for review.

I agree with cmlara: The project doesn't contain much PHP code, and all the code has been written by other users. There isn't much to be changed in the PHP code, which means that temlife cannot show what knows about writing secure code that follows the Drupal coding standards and that correctly uses the Drupal API.

@temlife You need to use a different project, if you want to get the vetted role these applications give.
These applications are per users, so we expect users to apply using a project for which they wrote code for at least a branch. They aren't applications for projects, for which the collective work done from more users is considered to change the project status.

The module missing tests at all, so only after that I think it viable to continue discussion

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear

function cmp_sirdata_help($route_name, RouteMatchInterface $route_match) {
  switch ($route_name) {
    case 'help.page.cmp_sirdata':
      $output = '';
      $output .= '<h3>' . t('About') . '</h3>';
      $output .= '<p>' . t('
        Sirdata CMP is a Consent Management Platform made to reply to privacy regulations such like GDPR, ePrivacy, CCPA and already used by thousands of websites.
      ') . '</p>';
      $output .= '<p>' . t('See more at <a href="@sirdata_cmp_docs">Sirdata CMP documentation page</a>.', ['@sirdata_cmp_docs' => 'https://cmp.docs.sirdata.net/']) . '</p>';

      return $output;
  }
}

The correct placeholder for URLs is :sirdata_cmp_docs, as described in FormattableMarkup::placeholderFormat().

I will make a review and resume of the observations.

Firstly Thanks All for the code review!!

#4, #7 About README with standards
Was fixed.

#10, #12 About code lines
Was Fixed

#10, #12 About several code committers
There is not a problem IMHO
The code is simple but is made by a team, and contributors are welcome. I think it is normal in an Open Source project.
The coding standards are already in revision.

phpcs \
    --standard="Drupal,DrupalPractice" -n \
    --extensions="*.*.yml,php,module,inc,install,test,profile,theme,md,js" \
    --ignore="*.features.*,*.pages*.inc,node_modules/*,css/*" \

Works without issues.

#12 About to get the "vetted role" for @temlife
Without comments.

#13 About to get tests
Was Fixed

#15 Is a good catch.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.