When a module uses the hook_eu_cookie_compliance_show_popup_alter to "disable" de popup it's better to add any html.

Currently the module adds the popup but it doesn't open it. In my case i add an overlay and some behaviours when the html popup is present, not if it's open. And it's more simple and clean if the html is not present.

CommentFileSizeAuthor
eu_cookie_compliance.module.show_no_html_when_excluded.patch1.46 KBcarlitus

Comments

Carlitus created an issue. See original summary.

svenryen’s picture

svenryen commented
Status: Active » Needs review

Thanks for the patch. We'll take a look, though we have added a feature to hide the banner visually and some people may rely on that functionality.

carlitus’s picture

carlitus commented

I think it's better to disable at alll, no only hidden. It's a lot cleaner and has less side effects.

svenryen’s picture

svenryen commented

I hear you, but it's hard to change a feature since we break the setup for so many sites.

svenryen’s picture

svenryen commented
Status: Needs review » Postponed (maintainer needs more info)

@Carlitus, would a suitable solution be a function you can call to tell if the banner is shown or hidden? We can't use your patch.

carlitus’s picture

carlitus commented

Hi @svenryen, and if it's for the next version? I don't think a function could be useful, but thanks :)

svenryen’s picture

svenryen commented

Why is that so? You would be able to call the function and then avoid showing the overlay if the banner is hidden.

carlitus’s picture

carlitus commented

Yes, sorry, you are right. I thinks it's better to do not have the popup div instead of hidden, but the function can be useful in this last case.

svenryen’s picture

svenryen commented
Status: Postponed (maintainer needs more info) » Active
svenryen’s picture

svenryen commented
Status: Active » Fixed

Committed. Thanks for your patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.