Found by @andy-blum in #3250357-16: Olivero: Elements within main content that have a high z-index will appear in front of mobile nav, the mobile menu can be covered up by the off-canvas dialog if it comes in from the top of the viewport.

We can fix this by using the Drupal.displace() function to determine where it needs to be fixed.

CommentFileSizeAuthor
#7 3251407-7.patch1.14 KBgauravvvv

Comments

mherchel created an issue. See original summary.

mherchel credited andy-blum.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: Olivero mobile menu should use Drupal.displace() to place the mobile menu » Olivero should use Drupal.displace() to place the mobile menu

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
Issue tags: -JavaScript +JavaScript
StatusFileSize
new 3251407-7.patch1.14 KB

I have attached a patch for same. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: -JavaScript +JavaScript

Patch doesn't match title or issue summary. So if that's the desired solution can issue summary be updated

Thanks.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Title: Olivero should use Drupal.displace() to place the mobile menu » Use Drupal.displace() to place the mobile menu
Status: Needs work » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.