The classes implemented by the cpliakas/git-wrapper library throw exceptions, but the module doesn't catch all of them, including the exception thrown by the GitWrapper constructor. The code should catch them, and log them when debugging is enabled.

Issue fork config_tools-3251367

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

apaderno created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed » Active
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: The code doesn't catch the exceptions thrown from the Gitwrapper constructor » The code doesn't catch the exceptions thrown from the cpliakas/git-wrapper library
Issue summary: View changes

I made the issue more generic, since there are more exceptions thrown from the cpliakas/git-wrapper library.

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues

beatrizrodrigues opened merge request !3

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned
Status: Active » Needs review

I moved the pieces of code that were instantiating GitWrapper into the try statement. I'm not sure if it was the right thing to do, so, please, review it and if you could give me some feedback it would be nice. Thank you so much.

  • beatrizrodrigues authored 487c0ca on 8.x-1.x 
    Issue #3251367 by beatrizrodrigues, apaderno: The code doesn't catch the...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.0.x-dev » 8.x-1.x-dev
Status: Needs review » Fixed

The change was correct. Thank you!
I committed the change also in the 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.