[D9] Language converter

Can you please A link to the project along with a git checkout command with the branch you wish to be reviewed as suggested in Application process description so that reviewers can be sure they are evaluating the correct project. You may want to look at other applications in the queue for a sample and normal formatting.

Additionally if you have not already done so you may want to work through the Security advisory coverage application checklist.

Please return to 'needs review' when this has been updated and you are ready for a review of your project.

@Praveen3555 You need to edit the issue summary and add that information, then change the status to Needs review.

Hi Praveen

git clone --branch '2.1.x' git@git.drupal.org:project/language_converter.git

above clone command is asking me for ssh keys, I guess it should be smothing like git clone https://git.drupalcode.org/project/language_converter.git.

Thank you for applying! main is a wrong branch name; the other branch names are correct. If main is the default branch, a different branch must be set as default; then the main branch can be deleted.

The main branch still needs to be deleted.

Automated Review

Please see attached pareview file for a more detailed list of concerns.

I recommend that you work through the Security advisory coverage application checklist as part of resolving the attached concerns.

• Utilize dependency injection.
• Missing Readme
• All global functions should be prefixed with your module/theme name (language_converter) to avoid name clashes. See https://www.drupal.org/node/318#naming
• All dependencies must be prefixed with the project name.
• @author tags are not normally used in Drupal projects.
• Incorrect spacing
• Files should end with a newline.
• Incorrect/incomplete comments/docblocs. (Capitalization, lack of termination, incorrect type, lacking parameters or parameter comments etc)
• Incorrect capitalization for TRUE, FALSE, or NULL.
• Namespace classes/interfaces/traits should be referenced by use.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Additionally how does this module differ from the existing Google translate modules currently available?

manual review:

1. class LanguageConverterAdminForm: The doc block just repeats the class name. Please add a useful description instead.
2. LanguageConverterAdminForm:: setttings: the data type doc block is wrong, this is a string, right?
3. config schema for your settings is missing, see https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-...
4. class ConverterClient: the use statements for the exceptions at the top of the file are wrong, they need to state the full namespace. Best use PHP IDE such as Visual Studio Cod with the intelephense plugin that will display such errors in your code.
5. ConvertAjaxController: the variable $source is undefined, do I see that correctly?
6. language_converter_form_alter(): I would prefix the form fields with your module name to avoid name clashes with others that might set "temporary_field" or "temporary_submit".

Otherwise looks good to me.

Thanks for your contribution, Praveen!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.