The properties in MigrateException have doc comments like this:
/**
* The level of the error being reported.
*
* The value is a Migration::MESSAGE_* constant.
*
* @var int
*/
protected $level;
/**
* The status to record in the map table for the current item.
*
* The value is a MigrateMap::STATUS_* constant.
*
* @var int
*/
protected $status;
The problem is that in an IDE or on api.d.o, those don't form links.
Each of these should have a @see line added to MigrateIdMapInterface and MigrationInterface respectively.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !1435
Comments
Comment #2
beatrizrodriguesI'll work on that :)
Comment #3
joachim commentedOk great!
Note that I was lazy and I didn't look up the full class names of MigrateIdMapInterface and MigrationInterface -- in the @see they need to be the namespaced class name.
Comment #4
beatrizrodriguesthanks @joachim I looked up the namespaces, but thank you for the reminder. I did the MR, I hope everything is right. Also, in the issue's description is saying that
So, I thought that the $level might have the MigrationInterface @see line, and the other, the MigrateIdMapInterface @see line. But I saw in the construct method, that was the opposite of that. I don't know if a got the description wrong or it was inverted indeed.
Comment #6
beatrizrodriguesSorry for the mess, I did the previous MR on the wrong version.
Comment #7
joachim commented> I don't know if a got the description wrong or it was inverted indeed
I got the order wrong in the issue summary, sorry!
RTBC -- the MR looks perfect. Thanks!
Comment #8
quietone commentedWith the suggested change the doc block has two different paths for the constants. I considered removing the sentences that start 'The value is a ...' but decided to keep them because they identify which constants are used. So, lets change those lines to point to the interface as well.
Comment #11
Tauany Bueno commentedhey, i'll review it :)
Comment #12
Tauany Bueno commentedHello!
I worked on the issue and fixed the problem mentioned on comment #8. Also, the MR from comment #9 removed some changes made by Beatriz that were correct.
I'm changing the status to needs review :)
ps: it needs to be rebased, however I saw that the option to rebase is available on GitLab, so I didn't work on this.
Comment #13
Tauany Bueno commentedI committed the wrong changes for comment #8. Made a new push to fix it :)
sorry for the mess
Comment #14
Joel Guerreiro Borghi Filho commentedHi! Will review =).
Comment #15
Joel Guerreiro Borghi Filho commentedAfter reviewing the code and talking to @tauanygb, I checked the latest changes, and they are looking good to me. Changing status to RTBC :)
Comment #16
quietone commented@Joel Guerreiro Borghi Filho, thanks for commenting on what you did to decide this was RTBC.
I resolved the threads in the MR.
I should be able commit this. I'll wait 48 hours for another committer to respond.
Comment #17
alexpottCommitted and pushed 88dceab07b to 10.1.x and be7f60d445 to 10.0.x and ae4cc2e6b3 to 9.5.x and 1ee191b795 to 9.4.x. Thanks!
Backported to 9.4.x since this is a docs improvement.