Problem/Motivation
Found in #3227518: Never show a "Not supported!" version as "Recommended" which has a similar problem for unsupported releases ,
update_calculate_project_update_status() has the message for the case if the current release is unpublished :
'Your currently installed release has been revoked, and is no longer available for download. Disabling everything included in this release or upgrading is strongly recommended!'
. This message doesn’t account for the case if there isn’t an available update.
It appears this code is 10 yrs old and probably no one has ever filed an issue for this problem, so marking it as minor.
Proposed resolution
Change the message for the case if there is no update available.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3250642
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #6
ranjit1032002Created MR!3935 for the issue mentioned, please review.
Thank You.
Comment #7
smustgrave commentedLanguage seems like someone is speaking directly to me vs announcing a description.
Comment #9
quietone commented@Ranjit1032002, thank you for making an MR. However, next time make sure you are changing the correct string. The string changed in the MR is for unsupported releases not revoked as is stated in the issue summary.
In my opinion, the existing test
Disabling everything included in this release or upgrading is strongly recommended!'handles the case where there is no update because it says to 'disable everything'. The suggested 'upgrading' is an option only. I will ask in #bugsmash and #ux.This is about the UI, so tagging.
@smustgrave, what documentation needs to be changed in this issue?
Comment #10
smustgrave commentedThink I used the wrong tag.
Comment #11
benjifisherWe discussed this issue briefly at #3377568: Drupal Usability Meeting 2023-08-04. That issue will have a link to a recording of the meeting.
For the record, the attendees at today's usability meeting were @AaronMcHale, @Emma Horrell, @benjifisher, @rkoller, @simohell, and @worldlinemine.
We decided that we did not have enough context to make an informed recommendation. How does a release get "revoked"? Does that mean unpublished, or is it specifically when the maintainer marks it as unsupported?
With that caveat, we tend to agree with #9.
Besides the question raised in this issue, the current message has some other problems. It refers to "disabling" a module, which is only possible in Drupal 7 and earlier.
Comment #12
benjifisher