[D8] Social Auth Vipps

Automated Review

Please see attached pareview.txt for full output.

• README.MD file is misnamed.
• It is customary to use all caps for section headers.
• Should not have a LICENSE file in repo.
• Should not access $_GET directly.
• Functions in .module should have module name prefixed, should be snake_case and have a docbloc.
• Verify use statement formatting and necessity.
• Code style around if () statement.
• Lines should be limited to 80 characters.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Still seeing formatting issues and warnings please fix this.

FILE: social_auth_vipps/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
16 | WARNING | Line exceeds 80 characters; contains 118 characters
22 | WARNING | Line exceeds 80 characters; contains 82 characters
24 | WARNING | Line exceeds 80 characters; contains 134 characters
39 | WARNING | Line exceeds 80 characters; contains 175 characters
46 | WARNING | Line exceeds 80 characters; contains 87 characters
56 | WARNING | Line exceeds 80 characters; contains 140 characters
60 | WARNING | Line exceeds 80 characters; contains 132 characters
68 | WARNING | Line exceeds 80 characters; contains 217 characters
70 | WARNING | Line exceeds 80 characters; contains 390 characters
78 | WARNING | Line exceeds 80 characters; contains 130 characters
----------------------------------------------------------------------

FILE: social_auth_vipps/social_auth_vipps.module
------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------
44 | ERROR | [ ] Missing parameter type
50 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /social_auth_vipps/src/Provider/Exception/EmailNotVerifiedException.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------
22 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------

Hi,

I have reviewd module, looks good to me but found only below accessibity issue.

social_auth_vipps.module

$form['login_with_vipps_button'] = [
      '#type' => 'item',
      '#markup' => sprintf("<div class='vipps-button-group'><a href='%s' class='%s' id = '%s'><img src='%s' alt=''></a></div>",
        Url::fromRoute('social_auth_vipps.redirect_to_vipps')->toString(),
        'login-with-vipps-link',
        'login-with-vipps-link',
        $btnImg
      ),
      '#weight' => -1,
    ];

In image tag there should be alt tag value for accisiblities for disable person. It would be good if alt can be configurable

About accessibility:
https://accessibility.psu.edu/images/imageshtml/#:~:text=Purpose,a%20tex....

@cristinahart,
I saw module file, But seems you forget to add translate to alt text

Hi @cristinahart,

Thanks for sharing a great module to drupal community. Now it looks good to me.

Looks Good

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.